Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Shim new platform - renaming vega -> vis_type_vega #41565

Merged
merged 2 commits into from
Jul 22, 2019
Merged

[Vega] Shim new platform - renaming vega -> vis_type_vega #41565

merged 2 commits into from
Jul 22, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

Part of #39915

2 Step of migrating to new Platform

What was done in this PR:

  • The existing vega plugin was moved into its own dedicated vis_type_vega plugin that adheres to the new platform plugin structure.
  • localization key for Vega plugin was changed from vega -> visTypeVega

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp changed the title [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega [Vega] Shim new platform - renaming vega -> vis_type_vega Jul 19, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp marked this pull request as ready for review July 19, 2019 10:29
@alexwizp alexwizp requested a review from a team as a code owner July 19, 2019 10:29
alexwizp
alexwizp commented Jul 19, 2019
View reviewed changes
src/legacy/core_plugins/vis_type_vega/index.ts
@@ -24,6 +24,9 @@ import { LegacyPluginApi, LegacyPluginInitializer } from '../../../../src/legacy

const vegaPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) =>
new Plugin({
// TODO: ID property should be changed from 'vega' to 'vis_type_vega'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukeelmers what should we do with it?
Not sure that we can rename vega.enableExternalUrls

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it as-is for now to prevent breaking things -- we need to figure out a bigger-picture strategy for how we want to deal with changes to configs & saved objects. But this is something that's easy enough to revisit later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe "easy" wasn't the best word to use... 😛 It's something we can wait on though

cchaos
cchaos approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just SASs file moves

@alexwizp alexwizp added Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0 labels Jul 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit 2a8ddb9 into elastic:master Jul 22, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 22, 2019
@alexwizp
[Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (e…
451aa20 
…lastic#41565)
@alexwizp alexwizp mentioned this pull request Jul 22, 2019
Merged
alexwizp added a commit that referenced this pull request Jul 22, 2019
@alexwizp
[Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (#…
e8385ac 
…41565) (#41650)
@lukeelmers lukeelmers mentioned this pull request Jul 22, 2019
Closed
8 tasks
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/rollup-jo…
4aeb768 
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
@alexwizp alexwizp deleted the vega-renaming branch January 4, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@cchaos cchaos cchaos approved these changes

@nreese nreese Awaiting requested review from nreese

@streamich streamich Awaiting requested review from streamich

@lizozom lizozom Awaiting requested review from lizozom

Assignees
No one assigned
Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @cchaos @lukeelmers