[APM] Local UI filters #41588
Merged
[APM] Local UI filters #41588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
retest |
💔 Build Failed |
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/app/ServiceOverview/ServiceList/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/shared/LocalFilters/Filter.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/shared/LocalFilters/Filter.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/shared/LocalFilters/Filter/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/shared/LocalFilters/Filter.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/components/shared/LocalFilters/Filter.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 20, 2019
sorenlouv
reviewed
Jul 20, 2019
x-pack/legacy/plugins/apm/public/context/UrlParamsContext/resolveUrlParams.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 21, 2019
x-pack/legacy/plugins/apm/server/lib/ui_filters/get_local_filters/index.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceOverview/ServiceList/index.tsx
Outdated
Show resolved
Hide resolved
|
That would be ideal, but I don't think we are there now (where we have
named routes & typed parameters). How would it look if we don't have named
routes & typed parameters?
…On Sun, Jul 21, 2019 at 11:14 AM Søren Louv-Jansen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
x-pack/legacy/plugins/apm/server/lib/ui_filters/get_local_filters/index.ts
<#41588 (comment)>:
> + setup: Setup;
+ server: Server;
+ type: DOCUMENT_TYPE;
+ uiFilters: UIFilters;
+}) {
+ const { start, end, client, config: kibanaConfig } = setup;
+
+ const typeConfig = config[type];
+
+ const localFilterAggregations = await Promise.all(
+ typeConfig.fields.map(async field => {
+ let filters = await getUiFiltersES(server, omit(uiFilters, field.name));
+
+ if (!filters.length) {
+ filters = [{ match_all: {} }];
+ }
Why is this necessary? If getUiFiltersES is empty it returns an empty
list, which is the same as matching all, right?
------------------------------
In
x-pack/legacy/plugins/apm/public/components/app/ServiceOverview/ServiceList/index.tsx
<#41588 (comment)>:
> @@ -50,7 +51,10 @@ export const SERVICE_COLUMNS = [
sortable: true,
render: (serviceName: string) => (
<EuiToolTip content={formatString(serviceName)} id="service-name-tooltip">
- <AppLink path={`/${serviceName}/transactions`}>
+ <AppLink
+ path={`/services/${serviceName}/transactions`}
+ documentType={DOCUMENT_TYPE.SERVICES}
When passing explicit query params, do you mean hard-coding them as props
to AppLink?
I'm thinking something like this:
<AppLink
routeName="transactionList"
params={{ serviceName, hostId }}
>
If we can infer the required and optional params from the routeName
What would then happen if we add or remove a local filter from the
configuration
I think the route config should decide what you can pass into links - not
the filter config. Those two should be decoupled imo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41588?email_source=notifications&email_token=AACWDXGY7CRMPBXNNR5MTETQAQSGBA5CNFSM4IFIK2F2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7CFYEI#pullrequestreview-264526865>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACWDXEMJQRLCOHORKZI6GDQAQSGBANCNFSM4IFIK2FQ>
.
|
|
Discussed via Zoom w/ @sqren (please correct me if I missed or misrepresented anything):
|
Yes, I think we should avoid creating a new "type" and just refer to the route names we already have. |
|
Agree with all the other points 👍 |
dgieselaar
force-pushed
the
local-filters
branch
from
29e983c
to
e32c1bf
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
local-filters
branch
from
e32c1bf
to
51ffa41
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
local-filters
branch
from
51ffa41
to
cbc2d12
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
local-filters
branch
from
cbc2d12
to
7368d45
Compare
dgieselaar
force-pushed
the
local-filters
branch
from
c3468cf
to
3653d59
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Aug 15, 2019
* Add snapshot tests for query search params * Use projections to fetch data * Add configuration and aggregations for local filters * Add endpoints for local filters * UseLocalUIFilters hook * Parse Local UI filters from URL params * LocalUIFilters component * TransactionTypeFilter * replace useServiceTransactionTypes with useTransactionTypes * Support transactionType for trace projection/api * Configure Local UI Filters * Use units instead of hardcoded px * Fix i18n error * Remove unused labels from translation files * Update URL of API integration test for transaction_types API call * Revert "replace useServiceTransactionTypes with useTransactionTypes" This reverts commit bae7fa4. * Revert "Support transactionType for trace projection/api" This reverts commit 2edb32c. * Remove transaction type filter for traces,error groups * Address review feedback * Don't clone in mergeProjection; add tests * Address review feedback * Revert transaction_types API path in functional tests * More review feedback * More review feedback: - Add transactions projection - Merge traces/transaction groups projections * Don't persist local UI filters in HistoryTabs * Move projections to server folder * Move transactionName into options * Use pod name instead of pod uid
dgieselaar
added a commit
that referenced
this pull request
Aug 15, 2019
* Add snapshot tests for query search params * Use projections to fetch data * Add configuration and aggregations for local filters * Add endpoints for local filters * UseLocalUIFilters hook * Parse Local UI filters from URL params * LocalUIFilters component * TransactionTypeFilter * replace useServiceTransactionTypes with useTransactionTypes * Support transactionType for trace projection/api * Configure Local UI Filters * Use units instead of hardcoded px * Fix i18n error * Remove unused labels from translation files * Update URL of API integration test for transaction_types API call * Revert "replace useServiceTransactionTypes with useTransactionTypes" This reverts commit bae7fa4. * Revert "Support transactionType for trace projection/api" This reverts commit 2edb32c. * Remove transaction type filter for traces,error groups * Address review feedback * Don't clone in mergeProjection; add tests * Address review feedback * Revert transaction_types API path in functional tests * More review feedback * More review feedback: - Add transactions projection - Merge traces/transaction groups projections * Don't persist local UI filters in HistoryTabs * Move projections to server folder * Move transactionName into options * Use pod name instead of pod uid
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
* Add snapshot tests for query search params * Use projections to fetch data * Add configuration and aggregations for local filters * Add endpoints for local filters * UseLocalUIFilters hook * Parse Local UI filters from URL params * LocalUIFilters component * TransactionTypeFilter * replace useServiceTransactionTypes with useTransactionTypes * Support transactionType for trace projection/api * Configure Local UI Filters * Use units instead of hardcoded px * Fix i18n error * Remove unused labels from translation files * Update URL of API integration test for transaction_types API call * Revert "replace useServiceTransactionTypes with useTransactionTypes" This reverts commit bae7fa4. * Revert "Support transactionType for trace projection/api" This reverts commit 2edb32c. * Remove transaction type filter for traces,error groups * Address review feedback * Don't clone in mergeProjection; add tests * Address review feedback * Revert transaction_types API path in functional tests * More review feedback * More review feedback: - Add transactions projection - Merge traces/transaction groups projections * Don't persist local UI filters in HistoryTabs * Move projections to server folder * Move transactionName into options * Use pod name instead of pod uid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34922.
Services:
Traces:
Transactions overview:
Transactions detail:
Errors:
Metrics:
Filter menu:
Definition of Done for APM UI
[ ] PM approval for bigger, user-facing features