Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds DF Transform Analytics list to Kibana management #43151

Merged
merged 8 commits into from
Aug 14, 2019
Merged

[ML] Adds DF Transform Analytics list to Kibana management #43151

merged 8 commits into from
Aug 14, 2019

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 12, 2019 •
edited
Loading

Summary

This PR is a follow up to #42570

  • Adds 'Analytics' tab with analytics table to ML/Jobs list section in Kibana management page.

image

image

  • Disables job id links in anomaly detection jobs tab when ML is not enabled in the current space
  • Removes action links in anomaly detection jobs tab when ML is not enabled in the current space

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@alvarezmelissa87 alvarezmelissa87 requested review from a team as code owners August 12, 2019 20:22
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-analytics-list-kibana-management branch from 473672d to edd9ca9 Compare August 13, 2019 14:36
@alvarezmelissa87 alvarezmelissa87 changed the title WIP [ML] Adds DF Transform Analytics list to Kibana management [ML] Adds DF Transform Analytics list to Kibana management Aug 13, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Added some questions about naming.

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js Outdated Show resolved Hide resolved
...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx
@@ -63,7 +63,11 @@ function stringMatch(str: string | undefined, substr: string) {
);
}

export const DataFrameAnalyticsList: FC = () => {
interface Props {
isManagementTable?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming nit: I'm afraid isManagementTable could be a bit confusing. It refers to the management section in Kibana, but seen alone here like this "management" could mean the opposite as in the capability to manage jobs where the table in Kibana management is view only. I'd like to suggest that we rename it to something that refers to the feature that the flag will enable/disable, something like isReadOnly or hideActions, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. 🤔 I'm not sure isReadOnly or something like that would fit since it's more that we're showing a different level of detail as well as removing actions when it's for the Kibana management view. This is the same prop name used in for the job management table so it would be consistent. Happy to change to something that makes more sense. Maybe in a small follow-up once we've decided on a name?

...k/legacy/plugins/ml/public/management/jobs_list/components/jobs_list_page/_expanded_row.scss Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

cchaos
cchaos reviewed Aug 14, 2019
View reviewed changes
...egacy/plugins/ml/public/management/jobs_list/components/jobs_list_page/_analytics_table.scss
// of the expanded row to 1000px which turned out to be not predictable.
// The animation could also result in flickering with expanded rows
// where the inner content would result in the DOM changing the height.
.euiTableRow-isExpandedRow .euiTableCellContent {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make an issue in EUI surrounding the problem you encountered so we can make the fix over there?

jgowdyelastic
jgowdyelastic approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 7aa7f5a into elastic:master Aug 14, 2019
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 14, 2019
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-analytics-list-kibana-management branch August 14, 2019 21:50
alvarezmelissa87 added a commit that referenced this pull request Aug 15, 2019
@alvarezmelissa87
[ML] Adds DF Transform Analytics list to Kibana management (#43151) (#…
8d76e57 
…43321)

* disable job link if ml not enabled in space

* add analytics table in managment page

* update css for analytics table

* only show ML section if license if trial/platinum

* remove actions column for analytics list in KM

* fix typescript error on columns

* update props interface for analytics table

* plain text instead of disabled link if not enabled in space
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 15, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/rollu…
0e96e99 
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (50 commits)
  [Uptime] update monitor list configs for mobile view (elastic#43218)
  [APM] Local UI filters (elastic#41588)
  [Code] Upgrade ctags langserver (elastic#43252)
  [Code] show multiple definition results in panel (elastic#43249)
  Adds Metric Type to full screen launch tracking (elastic#42692)
  [Canvas] Convert Autocomplete to Typescript (elastic#42502)
  [telemetry] add spacesEnabled config back to xpack_main (elastic#43312)
  [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151)
  Add TLS client authentication support. (elastic#43090)
  [csp] Telemetry for csp configuration (elastic#43223)
  [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804)
  docs: add tip on agent config in a dt (elastic#43301)
  [ML] Adding bucket span estimator to new wizards (elastic#43288)
  disable flaky tests (elastic#43017)
  Fix percy target branch for PRs (elastic#43160)
  [ML] Adding post create job options (elastic#43205)
  Restore discover histogram selection triggering fetch (elastic#43097)
  Per panel time range (elastic#43153)
  [Infra UI] Add APM to Metadata Endpoint (elastic#42197)
  Sentence case copy changes (elastic#43215)
  ...
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 16, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra walterra approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
:ml release_note:enhancement v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alvarezmelissa87 @elasticmachine @walterra @cchaos @jgowdyelastic