Sentence case copy changes #43215
Merged
Sentence case copy changes #43215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipb
added
Feature:Metrics UI
|
Pinging @elastic/infra-logs-ui |
Titch990
reviewed
Aug 13, 2019
There was a problem hiding this comment.
Fast work! Looks good, except I think "Min and "Max" above should probably be "min" and "max" respectively, unless you are referring to fields that appear elsewhere in the UI as "Min" and "Max". Sorry I can't approve this for you as it looks like you have a few code changes too and I'm not a developer. You'll need someone on the dev team to check those.
x-pack/legacy/plugins/infra/public/components/metrics_explorer/chart_options.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
simianhacker
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
,--, ,----, ,---,
,--. ,---.'| ,/ .`|,`--.' |
,--.'| ,---, ,---,| | : ,---,. ,---, ,---, ,` .' :| : :
,--,: : | ' .' \ ,`--.' |: : | ,' .' | .' .' `\ ,`--.' | ; ; /' ' ;
,`--.'`| ' : / ; '. | : :| ' : ,---.' |,---.' \ | : :.'___,/ ,' | | |
| : : | |: : \ : | '; ; ' | | .'| | .`\ | : | '| : | ' : ;
: | \ | :: | /\ \ | : |' | |__ : : |-,: : | ' | | : |; |.'; ; | | '
| : ' '; || : ' ;. :' ' ;| | :.'|: | ;/|| ' ' ; : ' ' ;`----' | | ' : |
' ' ;. ;| | ;/ \ \ | |' : ;| : .'' | ; . | | | | ' : ; ; | ;
| | | \ |' : | \ \ ,' : ;| | ./ | | |-,| | : | ' ' : ; | | ' `---'. |
' : | ; .'| | ' '--' | | '; : ; ' : ;/|' : | / ; | | ' ' : | `--..`;
| | '`--' | : : ' : || ,/ | | \| | '` ,/ ' : | ; |.' .--,_
' : | | | ,' ; |.' '---' | : .'; : .' ; |.' '---' | |`.
; |.' `--'' '---' | | ,' | ,.' '---' `-- -`, ;
'---' `----' '---' '---`"
,--, ,----,
,---.'| ,/ .`| ____
| | : ,----.. ,` .' : ,' , `.
: : | / / \ ; ; / ,-+-,.' _ |
| ' : | : :.'___,/ ,' ,-+-. ; , ||
; ; ' . | ;. /| : | ,--.'|' | ;|
' | |__ . ; /--` ; |.'; ;| | ,', | ':
| | :.'|; | ; __`----' | || | / | | ||
' : ;| : |.' .' ' : ;' | : | : |,
| | ./ . | '_.' : | | '; . | ; |--'
; : ; ' ; : \ | ' : || : | | ,
| ,/ ' | '/ .' ; |.' | : ' |/
'---' | : / '---' ; | |`-'
\ \ .' | ;/
`---` '---'
💚 Build Succeeded |
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Aug 14, 2019
* Change casing for options and labels to be sentence case * More sentence-case copy changes * Fix min and max capitalization
phillipb
added a commit
that referenced
this pull request
Aug 14, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
* Change casing for options and labels to be sentence case * More sentence-case copy changes * Fix min and max capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update copy across the infrastructure tab to be sentence-case instead
Fixes #43039
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility