histogram: option to enable/disable zero-fill #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using this feature allowing creating what are effectively timeline charts like this: |
|
hey, thats super cool! |
|
Hmm, like the idea here, except the option doesn't actually disable filling, but rather replaces it with null fills. It might be smarter to change this to a small "Gap Fill" drop down with 3 options:
|
|
Good idea! I'll try to make this change next week. |
|
@rashidkpc I went ahead and added another reduce strategy for filling:
How does this look? |
For some graph types (particularly point style), it's useful to explicitly avoid filling missing data points with zeros. For example, when plotting the min/max/mean value of a particular field, filling with zeros might present the wrong picture of the data, since the value is not actually zero but simply missing.
|
Rebased to better match latest style. @rashidkpc, how does this look? |
Closed
| @@ -17,6 +17,10 @@ | |||
| <label class="small">xAxis</label><input type="checkbox" ng-model="panel['x-axis']" ng-checked="panel['x-axis']"></div> | |||
| <div class="editor-option"> | |||
| <label class="small">yAxis</label><input type="checkbox" ng-model="panel['y-axis']" ng-checked="panel['y-axis']"></div> | |||
| <div class="editor-option" ng-hide="panel.derivative"> | |||
| <label class="small">Gap Fill</label> | |||
| <select class="input-mini" ng-model="panel.gapfill" ng-options="f for f in ['all','null','no']"> | |||
There was a problem hiding this comment.
This line is missing a closing select tag. Used like this it overwrites the Line Fill Option.
Otherwise a very useful change, that I'd love to see merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some graph types (particularly point style), it's useful to
explicitly avoid filling missing data points with zeros. For example,
when plotting the min/max/mean value of a particular field, filling with
zeros might present the wrong picture of the data, since the value is
not actually zero but simply missing.