[Reporting] Consolidate Server Type Defs, move some out of Legacy #66144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/move-class-ts-typedefs
branch
6 times, most recently
from
2b340d4
to
84facc7
Compare
tsullivan
changed the title
tsullivan
force-pushed
the
reporting/move-class-ts-typedefs
branch
6 times, most recently
from
438479f
to
8b0c99f
Compare
tsullivan
force-pushed
the
reporting/move-class-ts-typedefs
branch
6 times, most recently
from
f5b81e8
to
31e1407
Compare
tsullivan
force-pushed
the
reporting/move-class-ts-typedefs
branch
from
31e1407
to
6e7725e
Compare
tsullivan
added
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
| import { CancellationToken } from '../../../../../plugins/reporting/common'; | ||
| import { JobDocPayload, JobParamPostPayload, ScrollConfig } from '../../server/types'; | ||
|
|
||
| export type RawValue = string | object | null | undefined; |
There was a problem hiding this comment.
Hrm, this type is pretty wide open, hopefully we can narrow it down at some point...
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 19, 2020
…astic#66144) * [Reporting] consolidate server types, move some to NP * Revert touching routes code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 19, 2020
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
tsullivan
added a commit
that referenced
this pull request
May 19, 2020
…cy (#66144) (#66947) * [Reporting] Consolidate Server Type Defs, move some out of Legacy (#66144) * [Reporting] consolidate server types, move some to NP * Revert touching routes code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * fix ts * fix ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Reporting route migration.
This PR changes around imports, moving most out of files named
types.d.tsand intoindex.ts. Many other definitions that do not referencelegacyhave been moved to the New Platform area of Reporting code.Why this PR is useful
It starts to move code in the direction of New Platform. Consolidating the type definitions means placing the definitions closer to where they're important. That makes it simpler to identify entire modules that can be relocated.
These changes provide a way for there to be a smaller next PR to move server libs to NP. The
ExportTypesRegistryandLevelLoggerwould be good options to move to NP next.Summary
cancellation_token, as moved types depend on ittypes.d.tsfiles by moving type definitions where they fit best, or toindex.tsfiles for module scopeLevelLoggerasLoggerbecause it conflicts with a core type name