[services/testSubjects] fix isDisplayed/isEnabled/isSelected, add waitForEnabled #66538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
commented
May 14, 2020
| log.debug(`TestSubjects.append(${selector}, ${text})`); | ||
| const input = await this.find(selector); | ||
| await input.click(); | ||
| await input.type(text); | ||
| } |
There was a problem hiding this comment.
since we don't clear input after click, retrying it may end up with the incorrect text
dmlemeshko
commented
May 14, 2020
| log.debug(`TestSubjects.doubleClick(${selector})`); | ||
| const element = await this.find(selector, timeout); | ||
| await element.moveMouseTo(); | ||
| await element.doubleClick(); | ||
| } |
There was a problem hiding this comment.
WebElementWrapper has retryCall with 3 attempts to finish the action:
public async doubleClick() {
await this.retryCall(async function clickMouseButton(wrapper) {
await wrapper.scrollIntoViewIfNecessary();
await wrapper
.getActions()
.doubleClick(wrapper._webElement)
.perform();
});
}
I don't think we need to use retry service here
dmlemeshko
commented
May 14, 2020
| }); | ||
| log.debug(`TestSubjects.isEnabled(${selector})`); | ||
| const element = await this.find(selector); | ||
| return await element.isEnabled(); |
There was a problem hiding this comment.
The same reason as with doubleClick
dmlemeshko
commented
May 14, 2020
| }); | ||
| log.debug(`TestSubjects.isDisplayed(${selector})`); | ||
| const element = await this.find(selector); | ||
| return await element.isDisplayed(); |
There was a problem hiding this comment.
The same reason as with doubleClick
dmlemeshko
commented
May 14, 2020
| }); | ||
| log.debug(`TestSubjects.isSelected(${selector})`); | ||
| const element = await this.find(selector); | ||
| return await element.isSelected(); |
There was a problem hiding this comment.
The same reason as with doubleClick
dmlemeshko
commented
May 14, 2020
| }); | ||
| log.debug(`TestSubjects.getVisibleText(${selector})`); | ||
| const element = await this.find(selector); | ||
| return await element.getVisibleText(); |
There was a problem hiding this comment.
The same reason as with doubleClick
dmlemeshko
added
v7.8.1
v7.9.0
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…usage-in-testSubjects
…mlemeshko/kibana into ftr/remove-retry-usage-in-testSubjects
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
May 18, 2020
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 18, 2020
…ic#66538) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 18, 2020
…ic#66538) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
May 19, 2020
… (#66941) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
May 19, 2020
… (#66942) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 19, 2020
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While reviewing #66322 I noticed that
testSubjects.isDisplayed()(.isEnabled/isSelected as well) always returnstruesince it is wrapped with retry service.It sounds like a bug or bad naming at least, so I went through
testSubjectsservice and removed retry usage where it may introduce flakiness or return an incorrect result,waitForEnabledwas added to retry until element displayed+enabledhttps://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/455/ 40x passed
Checklist
Delete any items that are not applicable to this PR.
For maintainers