[Discover] Unskip doc link functional test #66884
Conversation
| ['extension', 'jpg'], | ||
| ['geo.src', 'IN'], | ||
| ]; | ||
|
|
There was a problem hiding this comment.
It's no necessary for the test to add columns and filters
| }); | ||
|
|
||
| it('should open the doc view of the selected document', async function() { | ||
| // navigate to the doc view | ||
| await docTable.clickRowToggle({ rowIndex: 0 }); | ||
| await (await docTable.getRowActions({ rowIndex: 0 }))[1].click(); |
There was a problem hiding this comment.
Here is the point where some failures happened. Maybe the navigation wasn't rendered / to late?
TypeError: Cannot read property 'click' of undefined
at Context.<anonymous> (test/functional/apps/discover/_doc_navigation.js:53:64)
at process._tickCallback (internal/process/next_tick.js:68:7)
but the screens I've got were not usefull, since they were scrolled down. In a future failure there should be a useful screen, also I thought that maybe a bit of sleep could prevent a possible race condition between opening the document detail and clicking the row action button.
There was a problem hiding this comment.
maybe a bit of sleep could prevent a possible race condition between opening the document detail and clicking the row action button
Sounds like what you want is a retry.waitFor(() => checkIfRowOpenedSomehow()). Putting an arbitrary sleep in here doesn't really prevent anything since the timing on CI is wildly unpredictable. Only way to add safeguards is with retries that are based on specific checks.
There was a problem hiding this comment.
Actually, even better:
// click the open action
await retry.try(async () => {
const rowActions = await docTable.getRowActions({ rowIndex: 0 });
if (!rowActions.length) {
throw new Error('row actions empty, trying again')
}
await rowActions[1].click()
})There was a problem hiding this comment.
agreed and adapted the code for this case, recent flaky run also just finished successfully (https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/465).
I'd love to have a kind of alert when this test would fail again
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…' of github.com:kertal/kibana into kertal-pr-2020-05-18-discover_dov_navigation_functional
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Co-authored-by: Spencer Alger <email@spalger.com>
Co-authored-by: Spencer Alger <email@spalger.com>
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
kertal
deleted the
kertal-pr-2020-05-18-discover_dov_navigation_functional
branch
Summary
While it wasn't possible to reproduce the flakiness of the test, neither with the flaky test runner, nor locally, I've improved the test for potential failings, and removed unnecessary actions.
Fixes #62281