[Security Solution][Ingest Manager][Endpoint] Optional ingest manager #71198

madirey · 2020-07-09T05:01:49Z

Summary

Makes ingestManager an optional dependency for securitySolution.

Ingest entirely disabled:

Ingest enabled:

Checklist

N/A

For maintainers

This was checked for breaking API changes and was labeled appropriately

This reverts commit 899a673.

elasticmachine · 2020-07-09T05:01:52Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-07-09T05:01:53Z

Pinging @elastic/endpoint-response (Team:Endpoint Response)

elasticmachine · 2020-07-09T05:01:54Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

kevinlog · 2020-07-09T11:43:31Z

@elasticmachine merge upstream

paul-tavares · 2020-07-09T12:23:10Z

👀

peluja1012 · 2020-07-09T13:35:05Z

x-pack/plugins/security_solution/public/plugin.tsx

-      'endpoint',
-      ConfigureEndpointPackageConfig
-    );
+    if (plugins.ingestManager) {


I think the problem with tests failing without this conditional should have been caught by typescript. Is it because we should have have also set the ingestManager StartPlugins type as optional? https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/types.ts#L35

@paul-tavares @XavierM @kevinlog thoughts?

@peluja1012 yeah, that sounds like it needs to be set to optional in the Type

paul-tavares · 2020-07-09T15:19:14Z

FYI - #70911
This PR will enable us to set Ingest Manager as optional without having to make additional code changes to avoid loading code that imports ingest manager code.

madirey · 2020-07-09T16:03:35Z

Also related: feb1202

paul-tavares · 2020-07-09T16:08:26Z

This PR should be held until @spalger merges #70911 . I just applied these changes ontop of his PR by adding ingestManager to the new Plugin kibana.json requiredBundles and we get the expected results.

kevinlog · 2020-07-10T12:50:29Z

@elasticmachine merge upstream

…nto optional-ingest-manager

…est-manager

kevinlog · 2020-07-10T16:28:11Z

x-pack/plugins/security_solution/kibana.json

@@ -33,6 +33,7 @@
  "requiredBundles": [
    "kibanaUtils",
    "esUiShared",
-    "kibanaReact"
+    "kibanaReact",
+    "ingestManager"


this is a new feature from kibana platform, see #70911

This allows us to still load the shared code that we import from ingestManager without the plugin actually being loaded. So, since "ingestManager" is optional we can either load it or not and the Administration section will handle accordingly.

There are existing tests that already checked the behavior of the Admin section with or without ingestManager either within Space or if the plugin is loaded at all.

kevinlog · 2020-07-10T16:52:56Z

@madirey @paul-tavares @alexk307 @peluja1012 I believe this one is ready to go. The kibana platform PR is in #70911

I pulled it down, tested it - Admin and other Security pages are working as expected. There are already tests in place to check the Admin pages when Ingest is disabled.

FYI @XavierM

kevinlog · 2020-07-10T18:54:03Z

Something else we can add here is a suite that doesn't enable ingestManager and, at the least, run through the Security tabs to ensure they still load and perhaps smoke test some basic functionality. I did this manually, but it would be good to have that automated as well, especially in the future as Ingest and Endpoint Admin develop further.

I put this up as a quick experiment with taking the ingestManager requirement out of the Security Cypress tests and it seems to work. #71370

My thought is that we could set up a similar suite and take this out of the config -https://github.com/elastic/kibana/pull/71370/files#diff-502bf387cf33d051febd25bc823df26dL49

Wondering what some thoughts are on approaches - @paul-tavares @XavierM ?

madirey · 2020-07-10T18:57:09Z

@kevinlog I know you're referring to UI functional tests, but just want to point out that we have something similar for the server-side APIs: https://github.com/elastic/kibana/tree/master/x-pack/test/endpoint_api_integration_no_ingest

kibanamachine · 2020-07-10T22:14:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a4b6218

Build metrics

✅ unchanged

History

💚 Build #60621 succeeded eb60b1b
💔 Build #60616 failed 19cc454
💔 Build #60156 failed c15576c
💔 Build #60069 failed dcf65a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…elastic#71198)

…#71198) (#71380) Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (78 commits) Bump lodash package version (elastic#71392) refactor: 💡 use allow-list in AppArch codebase (elastic#71400) improve bugfix 7198 test stability (elastic#71250) [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198) [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172) [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269) [Security Solution] Allow to configure Event Renderers settings (elastic#69693) Fix a11y keyboard overlay (elastic#71214) [APM] UI text updates (elastic#71333) [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113) [SIEM] fix tooltip of notes (elastic#71342) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) ...

madirey added 2 commits July 9, 2020 00:56

Revert "Reverting ingestManager back to being required for now"

cd269b3

This reverts commit 899a673.

Disable package config component when ingestManager is disabled

dcf65a4

madirey added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 9, 2020

madirey requested review from a team as code owners July 9, 2020 05:01

madirey assigned peluja1012 and alexk307 Jul 9, 2020

madirey unassigned peluja1012 and alexk307 Jul 9, 2020

Merge branch 'master' into optional-ingest-manager

c15576c

remove management plugin

b46b9e0

peluja1012 reviewed Jul 9, 2020

View reviewed changes

alexk307 approved these changes Jul 9, 2020

View reviewed changes

paul-tavares mentioned this pull request Jul 9, 2020

[kbn/optimizer] implement "requiredBundles" property of KP plugins #70911

Merged

elasticmachine and others added 2 commits July 10, 2020 06:50

Merge branch 'master' into optional-ingest-manager

824d637

Merge branch 'optional-ingest-manager' of github.com:madirey/kibana i…

fdc3329

…nto optional-ingest-manager

kevinlog added 2 commits July 10, 2020 09:13

Merge branch 'master' of github.com:kevinlog/kibana into optional-ing…

19cc454

…est-manager

correct plugin

eb60b1b

kevinlog reviewed Jul 10, 2020

View reviewed changes

make ingest type optional

a4b6218

peluja1012 approved these changes Jul 10, 2020

View reviewed changes

kevinlog merged commit e1253ed into elastic:master Jul 10, 2020

kevinlog deleted the optional-ingest-manager branch July 10, 2020 22:23

kevinlog mentioned this pull request Jul 10, 2020

[7.x] [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (#71198) #71380

Merged

kevinlog pushed a commit to kevinlog/kibana that referenced this pull request Jul 10, 2020

[Security Solution][Ingest Manager][Endpoint] Optional ingest manager (…

336369c

…elastic#71198)

aisantos added the Automated Test Cases To Be Documented label Jul 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Ingest Manager][Endpoint] Optional ingest manager #71198

[Security Solution][Ingest Manager][Endpoint] Optional ingest manager #71198

madirey commented Jul 9, 2020 •

edited by kevinlog

Loading

elasticmachine commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

kevinlog commented Jul 9, 2020

paul-tavares commented Jul 9, 2020

peluja1012 Jul 9, 2020

paul-tavares Jul 9, 2020

paul-tavares commented Jul 9, 2020

madirey commented Jul 9, 2020

paul-tavares commented Jul 9, 2020

kevinlog commented Jul 10, 2020

kevinlog Jul 10, 2020

kevinlog commented Jul 10, 2020

kevinlog commented Jul 10, 2020

madirey commented Jul 10, 2020

kibanamachine commented Jul 10, 2020

[Security Solution][Ingest Manager][Endpoint] Optional ingest manager #71198

[Security Solution][Ingest Manager][Endpoint] Optional ingest manager #71198

Conversation

madirey commented Jul 9, 2020 • edited by kevinlog Loading

Summary

Checklist

For maintainers

elasticmachine commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

kevinlog commented Jul 9, 2020

paul-tavares commented Jul 9, 2020

peluja1012 Jul 9, 2020

Choose a reason for hiding this comment

paul-tavares Jul 9, 2020

Choose a reason for hiding this comment

paul-tavares commented Jul 9, 2020

madirey commented Jul 9, 2020

paul-tavares commented Jul 9, 2020

kevinlog commented Jul 10, 2020

kevinlog Jul 10, 2020

Choose a reason for hiding this comment

kevinlog commented Jul 10, 2020

kevinlog commented Jul 10, 2020

madirey commented Jul 10, 2020

kibanamachine commented Jul 10, 2020

💚 Build Succeeded

Build metrics

History

madirey commented Jul 9, 2020 •

edited by kevinlog

Loading