-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lodash package version #71392
Bump lodash package version #71392
Conversation
Needed to bump cypress because it included a transitive dependency of lodash that was pegged to `4.7.15`.
This reverts commit 4c0c63a.
4.10.0
and lodash to 4.7.19
4.10.0
and lodash to 4.17.19
4.10.0
and lodash to 4.17.19
Flaky test looks unrelated, opening this up for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # package.json # yarn.lock
* master: (78 commits) Bump lodash package version (elastic#71392) refactor: 💡 use allow-list in AppArch codebase (elastic#71400) improve bugfix 7198 test stability (elastic#71250) [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198) [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172) [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269) [Security Solution] Allow to configure Event Renderers settings (elastic#69693) Fix a11y keyboard overlay (elastic#71214) [APM] UI text updates (elastic#71333) [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113) [SIEM] fix tooltip of notes (elastic#71342) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) ...
Needed to revert this as it breaks the yarn cache, not sure the right course of action to correctly fix this, but ideally we can get it working in a way that doesn't cause additional errors to be logged by yarn and doesn't break the yarn cache. |
Any idea what part of the yarn cache was breaking? Perhaps it's because I added the dependency resolution for cypress? |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
My guess is that it's related the yarn warning about an ignored "invalid" lodash version in yarn.lock. I have no idea what's causing the error, but I bet we've hit a yarn bug cause by the way resolutions are defined for several different lodash instances |
I figured out what broke the yarn caching (user error). Re-submitted this PR as #73122. |
Overview:
4.17.15
->4.17.19
Needed to bump cypress because it included a transitive dependency of lodash that was pegged to4.17.15
.#67961 previously updated cypress to4.5.0
but was unable to use the latest at the time (4.7.0
) because of a regression concerning authenticated URLs.That regression was fixed in4.8.0
.Update: I was mistaken, while the latest version of cypress (
4.10.0
) does include the fix for that regression, it's still pegged to the same version of lodash. The repo has a PR that merged to update lodash, but they haven't cut a new release of cypress yet. Instead, I left cypress as-is, added a yarn dependency resolution, and called it a day.