[build] Create Linux aarch64 package #69165

tylersmalley · 2020-06-15T15:28:19Z

Updates Linux Chromium builds to accept architecture argument (defaults to x64) for arm64 support.
- Example: python ~/chromium/build_chromium/build.py 312d84c8ce62810976feda0d3457108a6dfff9e6 arm64
Updates all Chromium builds to include architecture in filename.
- chromium-312d84c-linux_arm64.zip (new)
- chromium-312d84c-linux.zip > chromium-312d84c-linux_x64.zip
Moves Chromium install from data directory to x-pack/plugins/reporting/chromium
Moves Chromium download cache from x-pack/plugins/reporting/.chromium to .chromium
Installs Chromium during build (closes Distributions should include an extracted Chromium #53664)
Updates build to be architecture aware (x64 and aarch64)
Removed Chromium debug logs, they were not helpful and can not be written inside the Kibana root. If we were to keep them, we would need to write to logging.dist.

Testing:

Google Cloud Storage Upload Report (example): Includes targets for all platforms
AWS EC2 is currently the only available environment with ARM available
Be sure to test reporting (start trial, add sample data, open dashboard, create report)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

elasticmachine · 2020-07-03T02:48:38Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-07-03T02:48:39Z

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

src/dev/build/lib/config.js

src/dev/build/lib/platform.js

tylersmalley · 2020-07-06T13:59:36Z

test/scripts/jenkins_build_kibana.sh

@@ -25,5 +25,6 @@ yarn run grunt functionalTests:ensureAllTestsInCiGroup;
 # Do not build kibana for code coverage run
 if [[ -z "$CODE_COVERAGE" ]] ; then
  echo " -> building and extracting OSS Kibana distributable for use in functional tests"
-  node scripts/build --debug --oss
+  # TEMP: build all platforms for PR testing
+  node scripts/build --debug --oss --all-platforms


Added for testing

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

spalger

Build changes LGTM

x-pack/plugins/reporting/server/browsers/install.ts

jbudz · 2020-07-06T17:38:59Z

can we chown kibana:kibana in post_install.sh? pre-extracting will cause root:root ownership now that the server isn't doing it

tylersmalley · 2020-07-06T20:10:42Z

Chatted with @jbudz - we're going to leave the permissions as it since it maintains the existing permissions. We can address permissions in a separate PR if we decide the change them.

x-pack/build_chromium/build.py

x-pack/plugins/reporting/server/browsers/chromium/paths.ts

x-pack/plugins/reporting/server/browsers/index.ts

joelgriffith

Changes LGTM

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tsullivan · 2020-07-09T22:45:46Z

Removed Chromium debug logs, they were not helpful and can not be written inside the Kibana root. If we were to keep them, we would need to write to logging.dist.

I second this and also want to say that the logs we are more interested in are the stderr and stdout from the Chromium process. We don't have an easy way to do that right now, but @joelgriffith is working on it 😄

src/dev/build/tasks/clean_tasks.js

x-pack/plugins/reporting/server/browsers/chromium/driver_factory/args.ts

tsullivan

I had a small nit about using fromRoot in the Reporting "paths" file, otherwise the Reporting changes LGTM!

x-pack/plugins/reporting/server/browsers/chromium/paths.ts

x-pack/plugins/reporting/server/browsers/download/ensure_downloaded.ts

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tsullivan

latest changes LGTM!

kibanamachine · 2020-07-10T01:01:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b903704

Build metrics

✅ unchanged

History

💔 Build #60471 failed f7621dc
💔 Build #60320 failed ce55fe8
💛 Build #60268 was flaky 33d213b
💚 Build #58969 succeeded 45bbc97
💚 Build #58556 succeeded bb2ae5b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

- Updates Linux Chromium builds to accept architecture argument (defaults to x64) for arm64 support. - Example: `python ~/chromium/build_chromium/build.py 312d84c8ce62810976feda0d3457108a6dfff9e6 arm64` - Updates all Chromium builds to include architecture in filename. - `chromium-312d84c-linux_arm64.zip` _(new)_ - `chromium-312d84c-linux.zip` > `chromium-312d84c-linux_x64.zip` - Moves Chromium install from data directory to `x-pack/plugins/reporting/chromium` - Moves Chromium download cache from `x-pack/plugins/reporting/.chromium` to `.chromium` - Installs Chromium during build (closes elastic#53664) - Updates build to be architecture aware (x64 and aarch64) - Removed Chromium debug logs, they were not helpful and can not be written inside the Kibana root. If we were to keep them, we would need to write to `logging.dist`. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .ci/packer_cache_for_branch.sh # x-pack/plugins/reporting/server/browsers/chromium/paths.ts

…11y-overlay * 'master' of github.com:elastic/kibana: (33 commits) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI Deduplication of entries and items before sending to endpoint (elastic#71297) [services/remote/webdriver] fix eslint error (elastic#71346) send slack notifications on visual baseline failures fix visual regression job (elastic#70999) [Ingest Manager] Add schema to usageCollector. (elastic#71219) [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279) [Ingest Manager] Fix limited packages incorrect response (elastic#71292) Support multiple features declaring same properties (elastic#71106) [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183) [DOCS] Clarify trial subscription levels (elastic#70636) ...

* master: (78 commits) Bump lodash package version (elastic#71392) refactor: 💡 use allow-list in AppArch codebase (elastic#71400) improve bugfix 7198 test stability (elastic#71250) [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198) [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172) [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269) [Security Solution] Allow to configure Event Renderers settings (elastic#69693) Fix a11y keyboard overlay (elastic#71214) [APM] UI text updates (elastic#71333) [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113) [SIEM] fix tooltip of notes (elastic#71342) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) ...

- Updates Linux Chromium builds to accept architecture argument (defaults to x64) for arm64 support. - Example: `python ~/chromium/build_chromium/build.py 312d84c8ce62810976feda0d3457108a6dfff9e6 arm64` - Updates all Chromium builds to include architecture in filename. - `chromium-312d84c-linux_arm64.zip` _(new)_ - `chromium-312d84c-linux.zip` > `chromium-312d84c-linux_x64.zip` - Moves Chromium install from data directory to `x-pack/plugins/reporting/chromium` - Moves Chromium download cache from `x-pack/plugins/reporting/.chromium` to `.chromium` - Installs Chromium during build (closes #53664) - Updates build to be architecture aware (x64 and aarch64) - Removed Chromium debug logs, they were not helpful and can not be written inside the Kibana root. If we were to keep them, we would need to write to `logging.dist`. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .ci/packer_cache_for_branch.sh # x-pack/plugins/reporting/server/browsers/chromium/paths.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

This was removed in elastic#69165 without realizing it was used by the packer cache. I renamed it to be more inline with what it actually does. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

This was removed in #69165 without realizing it was used by the packer cache. I renamed it to be more inline with what it actually does. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

This was removed in elastic#69165 without realizing it was used by the packer cache. I renamed it to be more inline with what it actually does. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .ci/packer_cache_for_branch.sh

This was removed in #69165 without realizing it was used by the packer cache. I renamed it to be more inline with what it actually does. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .ci/packer_cache_for_branch.sh

cartreran · 2020-09-09T01:23:47Z

Why isnt this avalaibe on the main page? I cant seem to find a downlaod

tylersmalley force-pushed the build-aarch-linux branch 2 times, most recently from c3a9649 to 4963f9b Compare June 23, 2020 14:48

tylersmalley force-pushed the build-aarch-linux branch 5 times, most recently from 7bd8839 to 5e2e834 Compare July 2, 2020 19:53

[build] Create Linux aarch64 package

bb2ae5b

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the build-aarch-linux branch from 5e2e834 to bb2ae5b Compare July 2, 2020 22:55

tylersmalley added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:enhancement Team:Operations Team label for Operations Team Team:Reporting Services v7.9.0 v8.0.0 labels Jul 3, 2020

tylersmalley marked this pull request as ready for review July 3, 2020 02:48

tylersmalley requested a review from a team as a code owner July 3, 2020 02:48

tylersmalley mentioned this pull request Jul 3, 2020

Distributions should include an extracted Chromium #53664

Closed

tylersmalley added the Feature:Build Packaging label Jul 3, 2020

tylersmalley requested a review from a team July 3, 2020 02:53

spalger reviewed Jul 3, 2020

View reviewed changes

src/dev/build/lib/config.js Outdated Show resolved Hide resolved

src/dev/build/lib/platform.js Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into build-aarch-linux

4cc3934

tylersmalley commented Jul 6, 2020

View reviewed changes

Throw when platform isn't found

45bbc97

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

spalger approved these changes Jul 6, 2020

View reviewed changes

jbudz reviewed Jul 6, 2020

View reviewed changes

x-pack/plugins/reporting/server/browsers/install.ts Show resolved Hide resolved

joelgriffith reviewed Jul 9, 2020

View reviewed changes

x-pack/build_chromium/build.py Outdated Show resolved Hide resolved

joelgriffith reviewed Jul 9, 2020

View reviewed changes

x-pack/plugins/reporting/server/browsers/chromium/paths.ts Outdated Show resolved Hide resolved

joelgriffith reviewed Jul 9, 2020

View reviewed changes

x-pack/plugins/reporting/server/browsers/index.ts Show resolved Hide resolved

joelgriffith approved these changes Jul 9, 2020

View reviewed changes

Tyler Smalley added 3 commits July 9, 2020 09:26

Updates paths

ce55fe8

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Reuse existing paths

63cafc9

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Merge remote-tracking branch 'upstream/master' into build-aarch-linux

f7621dc

tsullivan mentioned this pull request Jul 9, 2020

[Reporting/Docs] Correct the explanation of Reporting setup within Kibana #71345

Closed

tsullivan reviewed Jul 9, 2020

View reviewed changes

src/dev/build/tasks/clean_tasks.js Show resolved Hide resolved

tsullivan reviewed Jul 9, 2020

View reviewed changes

x-pack/plugins/reporting/server/browsers/chromium/driver_factory/args.ts Show resolved Hide resolved

tsullivan requested changes Jul 9, 2020

View reviewed changes

x-pack/plugins/reporting/server/browsers/chromium/paths.ts Show resolved Hide resolved

x-pack/plugins/reporting/server/browsers/download/ensure_downloaded.ts Show resolved Hide resolved

Tyler Smalley added 2 commits July 9, 2020 16:22

Merge remote-tracking branch 'upstream/master' into build-aarch-linux

95605ef

Updates docs

b903704

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tsullivan approved these changes Jul 9, 2020

View reviewed changes

tylersmalley merged commit afe785b into elastic:master Jul 10, 2020

tylersmalley mentioned this pull request Jul 10, 2020

[7.x] [build] Creates Linux aarch64 archive (#69165) #71358

Merged

tylersmalley mentioned this pull request Jul 14, 2020

Restores task for downloading Chromium builds #71749

Merged

tylersmalley mentioned this pull request Jul 22, 2020

Introduce Linux aarch64 package #61507

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Create Linux aarch64 package #69165

[build] Create Linux aarch64 package #69165

tylersmalley commented Jun 15, 2020 •

edited

Loading

elasticmachine commented Jul 3, 2020

elasticmachine commented Jul 3, 2020

tylersmalley Jul 6, 2020

spalger left a comment

jbudz commented Jul 6, 2020

tylersmalley commented Jul 6, 2020

joelgriffith left a comment

tsullivan commented Jul 9, 2020

tsullivan left a comment

tsullivan left a comment

kibanamachine commented Jul 10, 2020

cartreran commented Sep 9, 2020

[build] Create Linux aarch64 package #69165

[build] Create Linux aarch64 package #69165

Conversation

tylersmalley commented Jun 15, 2020 • edited Loading

elasticmachine commented Jul 3, 2020

elasticmachine commented Jul 3, 2020

tylersmalley Jul 6, 2020

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

jbudz commented Jul 6, 2020

tylersmalley commented Jul 6, 2020

joelgriffith left a comment

Choose a reason for hiding this comment

tsullivan commented Jul 9, 2020

tsullivan left a comment

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 10, 2020

💚 Build Succeeded

Build metrics

History

cartreran commented Sep 9, 2020

tylersmalley commented Jun 15, 2020 •

edited

Loading