-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[index patterns] Fleep app - Keep saved object field list until field caps provides fields #85370
[index patterns] Fleep app - Keep saved object field list until field caps provides fields #85370
Conversation
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
@jonathan-buttner do you think the failing endpoint test is related to our changes? |
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoint changes LGTM ;)
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (note: I did not test the migration locally)
- Should we be applying the migration for
7.11.1
at this point? - Super nit: I think
requireIndex
would be easier to grok thanallowNoIndex
, but that's a bit of a subjective opinion.
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresX-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/network_policy·ts.Reporting APIs Network Policy should fail job when page voilates the network policyStandard Out
Stack Trace
Metrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
… caps provides fields (elastic#85370)
… caps provides fields (elastic#85370) # Conflicts: # src/plugins/data/public/public.api.md
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
Summary
The Fleet app needs an index pattern field list to exist before documents do so that the dashboards it installs don't show errors before there's data. It provides a field list via the index pattern saved object. Index patterns need to use it until field caps provides a complete response.
Plans
logs-*
andmetrics-*
index patterns provided by Fleet will have a flag that will ignore field caps 404 errors.metrics-*
andlogs-*
Checklist
Delete any items that are not applicable to this PR.