-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set Elasticsearch heap size during CI and local development #86513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Team:Operations
Team label for Operations Team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:CI
Continuous integration
v7.11.0
v7.12.0
v7.10.1
labels
Dec 18, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Dec 18, 2020
This was referenced Dec 18, 2020
Merged
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Dec 18, 2020
brianseeders
added a commit
that referenced
this pull request
Dec 19, 2020
brianseeders
added a commit
that referenced
this pull request
Dec 19, 2020
brianseeders
added a commit
that referenced
this pull request
Dec 19, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 21, 2020
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.10.1
v7.11.0
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See elastic/elasticsearch#65905 and elastic/elasticsearch#66567
Elasticsearch is now, by default, setting the min heap size to 50% of the machines memory. This causes a problem in CI, because we are running 10+ instances of ES on the same machine, and each one tries to allocate 50%. It will also allocate way more than is necessary for local dev.
This quick fix should explicitly set the heap size to the old default (1g). Let me know if there's a better place/way to do it. If the heap size ever needs to be set for specific suites, we may want to consider moving it to a separate option. For now, I didn't see any instances of it being explicitly set anywhere.
This should also allow us to scale the machine size back down for ES snapshot jobs, and should allow snapshots to be verified again.