[APM] Add experimental support for Data Streams #89650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
commented
Jan 28, 2021
|
What about:
We probably don't need to update them all. But I was a bit surprised by how many (hardcoded) references there are to apm-* so at least wanted to mention some I found. |
Good point. I initially thought we'd just make the UI usable for fleet users and then ignore everything else until 8.0. But thinking again it'll be a bad experience if the permissions, ML jobs etc don't work out of the box as expected. Wrt permissions I think adding the new data stream indices to the apm_user role will be fairly straight forward. Similarly, I hope we can make ML jobs work for other indices than Not sure what we'll do with the index pattern. Not sure an index pattern can span across different indicies that don't share a common prefix. So we might have to create an alias for this |
sorenlouv
force-pushed
the
add-data-streams-indicies
branch
from
a32a7ed to
23879a0
Compare
sorenlouv
added
release_note:skip
sorenlouv
changed the title
|
@elasticmachine merge upstream |
|
retest |
sorenlouv
commented
Feb 8, 2021
src/plugins/apm_oss/server/index.ts
Outdated
| @@ -21,6 +21,7 @@ export const config = { | |||
| sourcemapIndices: schema.string({ defaultValue: 'apm-*' }), | |||
| onboardingIndices: schema.string({ defaultValue: 'apm-*' }), | |||
| indexPattern: schema.string({ defaultValue: 'apm-*' }), | |||
| fleet: schema.boolean({ defaultValue: true }), | |||
There was a problem hiding this comment.
Option to disable fleet support. Should it be called something else like fleet.enabled?
sorenlouv
commented
Feb 8, 2021
| @@ -66,7 +66,7 @@ export function KueryBar(props: { prepend?: React.ReactNode | string }) { | |||
|
|
|||
| const example = examples[processorEvent || 'defaults']; | |||
|
|
|||
| const { indexPattern } = useDynamicIndexPatternFetcher(processorEvent); | |||
| const { indexPattern } = useDynamicIndexPatternFetcher(); | |||
There was a problem hiding this comment.
Removed processorEvent from the dynamic index pattern. It barely had an impact since 850 fields of 905 are shared. So limiting to a single processorEvent didn't have any significant advantages.
sorenlouv
commented
Feb 8, 2021
| endpoint: 'GET /api/apm/index_pattern/dynamic', | ||
| isCachable: true, | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
Another benefit of removing processorEvent: a dynamic index pattern is now only fetched once.
smith
approved these changes
Feb 9, 2021
sorenlouv
force-pushed
the
add-data-streams-indicies
branch
from
5fac944 to
d8d0175
Compare
|
jenkins run the e2e |
|
@elasticmachine merge upstream |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2021
* master: (44 commits) [APM] Add experimental support for Data Streams (elastic#89650) [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818) [Lens] Median as default function (elastic#90952) Implement custom global header banner (elastic#87438) [Fleet] Reduce permissions. (elastic#90302) Update dependency @elastic/charts to v24.5.1 (elastic#89822) [Create index pattern] Can't create single character index without wildcard (elastic#90919) [ts/build_ts_refs] add support for --clean flag (elastic#91060) Don't clean when running e2e tests (elastic#91057) Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068) [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895) Removing the code plugin entirely for 8.0 (elastic#77940) chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026) [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020) [Fleet] Restrict integration changes for managed policies (elastic#90675) [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042) [DOCS] Uses variable to refer to query profiler (elastic#90976) [App Search] Relevance Tuning logic listeners (elastic#89461) [Metrics UI] Fix saving/loading saved views from URL (elastic#90216) Limit cardinality of transaction.name (elastic#90955) ...
2 tasks
dgieselaar
added a commit
that referenced
this pull request
Feb 13, 2021
* [APM] Add experimental support for Data Streams (#89650) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Update mock types for apm oss Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Closed
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/grok_debugger/grok_debugger·js.logstash grok debugger app "before all" hook in "grok debugger app"Standard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/modules/setup_module·ts.apis Machine Learning modules module setup sets up module data for logs_ui_categories with prefix, startDatafeed true and estimateModelMemory trueStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87501
kibana_systemrole (Add read permissions forapm_userrole to APM fleet indices elasticsearch#68749)apm_userrole to APM fleet indices elasticsearch#68749)