Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create index pattern] Can't create single character index without wildcard #90919

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 10, 2021

Summary

Can't create single character index without wildcard

Steps to reproduce

  1. Start Kibana and open Kibana Dev Tools
  2. Create new ES indexed using the following command:
PUT /a
  1. Go to Stack Management -> Index patterns -> Create index pattern to create new kibana index.

Expected behavior:
User should be able to create index a

Actual behavior:
User can only create index "a*" (wildcard cannot be removed)

Screen:

Screen.Recording.2021-02-10.at.2.06.03.PM.mov

This PR fixes that wrong behaviour, one-character-index can be created.
image

@alexwizp alexwizp self-assigned this Feb 10, 2021
@alexwizp alexwizp marked this pull request as ready for review February 10, 2021 11:11
@alexwizp alexwizp added v7.12.0 v8.0.0 release_note:fix Feature:Index Management Index and index templates UI Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 556.0KB 556.0KB +32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@alexwizp alexwizp merged commit 7d9b4ed into elastic:master Feb 11, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 11, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2021
* master: (44 commits)
  [APM] Add experimental support for Data Streams (elastic#89650)
  [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818)
  [Lens] Median as default function (elastic#90952)
  Implement custom global header banner (elastic#87438)
  [Fleet] Reduce permissions. (elastic#90302)
  Update dependency @elastic/charts to v24.5.1 (elastic#89822)
  [Create index pattern] Can't create single character index without wildcard (elastic#90919)
  [ts/build_ts_refs] add support for --clean flag (elastic#91060)
  Don't clean when running e2e tests (elastic#91057)
  Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068)
  [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895)
  Removing the code plugin entirely for 8.0 (elastic#77940)
  chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026)
  [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020)
  [Fleet] Restrict integration changes for managed policies (elastic#90675)
  [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042)
  [DOCS] Uses variable to refer to query profiler (elastic#90976)
  [App Search] Relevance Tuning logic listeners (elastic#89461)
  [Metrics UI] Fix saving/loading saved views from URL (elastic#90216)
  Limit cardinality of transaction.name (elastic#90955)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants