Support Drag & Drop of images from other browser windows into RoomView

[enko]

It would be nice if you can drag an Image from a website and drop it into the chat view and have it uploaded.

I do not know if this is possible, but it would make the channel with my wife sooo mich nicer, because I could upload the images/gifs directly via d'n'd and would not need to safe them localy.

[ara4n]

This should be doable - Google Image Search already supports it. It's probably a very easy modification to the DND code to accept images from browsers as well as boring old files.

[ara4n]

see https://matrix.org/_matrix/media/v1/download/matrix.org/bbLqwmAsEADLWKLxIoxOpeiy

[status-open-bounty]

Current balance: 0.0 ETH
Tokens: SNT: 6000.00
Contract address: 0x936dfd4edefa099b88eb8e6c94a18df7d00bb95b

Network: Mainnet
To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.
To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

[monokh]

I started to have a look at this but hit a roadblock.
On drag and drop of an image, the only thing that is available is the URL for that image. My initial plan of action was to fetch this or pull the data from a canvas and construct a File object to pass through however this is not possible. Due to cors, an image cannot be loaded cross origin.

I had a look at how google does this. They forward the url of the image to their server to be uploaded. Does riot have such an upload endpoint as well?

[lampholder]

We don't have such an endpoint today.

This could be implemented by adding a method to the media repository to support ingesting a piece of content from a provided URL rather than the request body.

We would need to think very carefully about what we were doing to make sure nobody could do anything nasty (e.g. have us DOS services on their behalf, or gain privilidged access to our systems by initiating HTTP requests from within our network). That said, we've already considered these issues for our implementation of the URL preview feature, so it shouldn't be too hard to apply to this feature, too.

[monokh]

@lampholder Ok that makes sense. So where/what actually is the media repository and how can I make changes to it? Some guidance would be helpful. I could probably get this issue and #1953 done together.

[GlulkAlex]

@monokh @lampholder
can this https://github.com/react-dropzone/react-dropzone be (directly) applicable ?

[oivoodoo]

@GlulkAlex it has already implemented in matrix-react-sdk. it's possible to upload files by dragging to RoomView.

[GlulkAlex]

Thanks, @oivoodoo .
It is a bit confusing that issues #3015 and #1953 are still open .
My bad, I must have done proper subject research beforehand .

[monokh]

@GlulkAlex The issue is that files are possible but dragging and dropping images from a web page is not. react-dropzone only works for files.

[GlulkAlex]

@monokh you mean something like Recommended_drag_types
or the image needs to be displayed wysiwyg inline ?

[BloodyIron]

This would be really cool! Also, if we could have Drag & Drop for URLs too (that aren't images) being pasted into chat?

[gotmyname2018]

I tried to fix this issue, and found most required works seems have been done by oivoodoo (#2751, #1689) and he is targeting this issue, if this is the case, I will not continue to work on this, is my understanding right?

[oivoodoo]

@gotmyname2018 yeah. I am working on it in free time, a bit stuck in synapse part, but it's really close to be published :)

[georgiemathews]

@oivoodoo is this still being worked on?

[BloodyIron]

Still interested in this!

[georgiemathews]

@BloodyIron I'm not sure how much progress has been made but I'm more than happy to give it a shot.

[oivoodoo]

Hi if you have enough time it would be better to give a try to work on the feature. Thank you!

…

On 12 May 2018 at 00:36, Georgie Mathews ***@***.***> wrote: @BloodyIron <https://github.com/BloodyIron> I'm not sure how much progress has been made but I'm more than happy to give it a shot. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3015 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADUxUjXkJigTyMyNMX7CD1K6DtHUaUUks5txgRvgaJpZM4LqLKQ> .

-- Best Regards, Alexandr skype: oivoodoo

[georgiemathews]

Implemented! You can check the status here: matrix-org/matrix-react-sdk#1893

[BloodyIron]

@georgiemathews awesome! :D

[georgiemathews]

@BloodyIron , you're better of tracking the progress already made here: matrix-org/matrix-react-sdk#1689 by @oivoodoo

[BloodyIron]

Any word on this? D:

[oivoodoo]

the pull request was closed as I remember because of requirements to have API changes that is still in proposal state.

…

On Tue, 17 Sep 2019 at 01:10, BloodyIron ***@***.***> wrote: Any word on this? D: — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3015>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAANJRLY2DHRVKDLQIPYFEDQKAG47ANCNFSM4C5IWKIA> .

-- Best Regards, Alexandr skype: oivoodoo

[rubo77]

Current balance: 0.0 ETH
Tokens: SNT: 6000.00
Contract address: 0x936dfd4edefa099b88eb8e6c94a18df7d00bb95b

Network: Mainnet
To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.
To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

openbounty.status.im seems dead, I hope nobody sent any ETH there? This was archived: https://github.com/status-im/open-bounty

[BloodyIron]

Any chance we can get this feature going?

[oivoodoo]

I would love to help, need to review the recent changes on the backend, in case if it's possible to implement I will finish it. Going to review it today.

[turt2live]

This appears to have been fixed at some point. Just dragged someone's random avatar to a DM and it uploaded fine.

[t3chguy]

Not working on Element Nightly on macOS at least

[turt2live]

(works on nightly for Windows)