Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

[FIX #3015] add api resolve media by url #3308

Closed

Conversation

oivoodoo
Copy link

@oivoodoo oivoodoo commented May 30, 2018

Hi everyone.

As part of this element-hq/element-web#3015 issue I've decided to add resolve_url rest api. I did the same approach with black urls like in the preview rest api.

reopened the pull request with the required changes.

pull requests:

Signed-off-by: Alexandr Korsak alex.korsak@gmail.com

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@richvdh
Copy link
Member

richvdh commented May 30, 2018

Thank you for your contribution on this; however, I've had a quick look at it, and I think you've put the cart before the horse here.

Remember that matrix is an open specification, and synapse is not the only server which needs to implement Client-Server APIs. Additions to that API need to be discussed before it is sensible to commit support into synapse. https://matrix.org/docs/spec/proposals describes the process for this in some detail. I think we'll need to reach some sort of consensus within the community before we can proceed here.

@oivoodoo
Copy link
Author

Hi @richvdh . everything makes sense. thank you for sharing the proper way to handle the new api for matrix. Going to create the proposal.

@richvdh
Copy link
Member

richvdh commented May 30, 2018

closing this for now. Let's reopen it once we have an agreement on the API.

@richvdh richvdh closed this May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants