[FIX #3015] Add drag drop urls room view, add resolve_url api #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2018
krombel
suggested changes
May 30, 2018
src/base-apis.js
Outdated
| * to 'default'. | ||
| * | ||
| * @param {string=} opts.type Content-type for the upload. Defaults to | ||
| * <tt>applicaton/octet-stream</tt>. |
There was a problem hiding this comment.
You don't implement usage of this parameter
src/http-api.js
Outdated
| } | ||
| }; | ||
| let url = this.opts.baseUrl + "/_matrix/media/v1/resolve_url"; | ||
| url += "?access_token=" + encodeURIComponent(this.opts.accessToken); |
There was a problem hiding this comment.
if this.useAuthorizationHeader is true we send the access token via "Authorization Bearer <auth_token" instead of query param.
src/base-apis.js
Outdated
| * @param {object} opts options object | ||
| * | ||
| * @param {string=} opts.name Name to give the file on the server. Defaults | ||
| * to 'default'. |
|
It looks like some changes were made and another review is needed. Requesting a fresh review. |
|
This is blocked on spec. |
|
Aha, thanks for the clarification. For future readers, there is a spec proposal waiting for review. |
|
With the spec proposal in review and the react-sdk side closed, plus the merge conflicts here, I'm going to go ahead and close this. I recommend pushing through on the spec side (which seems to have outstanding comments) and getting some form of consensus before opening a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
As part of this issue(element-hq/element-web#3015) I were working on resolve api(matrix-org/synapse#2751) in synapse project and now it would require to integrate together.
By using resolve api as part of media api of synapse project it will solve CORS requests issue.
pull requests:
Signed-off-by: Alexandr Korsak alex.korsak@gmail.com