Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display name and avatar changes aren't "read" properly if user prefs hide them #9518

Open
cuibonobo opened this issue Apr 17, 2019 · 2 comments
Open

Display name and avatar changes aren't "read" properly if user prefs hide them #9518

cuibonobo opened this issue Apr 17, 2019 · 2 comments
Labels
A-Notifications A-Read-Receipts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@cuibonobo
Copy link

cuibonobo commented Apr 17, 2019 •
edited
Loading

Description

If "Show avatar changes" and "Show display name changes" are checked off in user preferences, visiting a room where the latest activity is avatar or display name changes will mark them as "read" locally, but not on the server. Clearing the cache will reveal those rooms as "unread".

Steps to reproduce

  • Disable "Show avatar changes" and "Show display name changes" in user preferences
  • Visit a room where the last activity was an avatar or display name change
  • Upon leaving the room, the room name is no longer bold, so it has been "read"
  • Clear the cache
  • The rooms that were previously "read" are "unread" again

It seems like rooms are marked as read locally, but not on the server.

Version information

  • Platform: Desktop
  • OS: Windows 10
  • Version: 1.0.8
@jryans jryans added the defect label Apr 18, 2019
@cuibonobo
Copy link
Author

Update to say this is still being observed in version 1.3.0.

@jryans jryans removed the defect label Mar 4, 2021
@kpfleming
Copy link

FYI, this is still the case with with 1.10.x, and the problem is readily apparent when using a Google Chat bridge to a room with lots of people in it... and those people use the 'away' status feature on the Google side. Those status changes appear to be reflected into Matrix as avatar changes, so in a room with hundreds of participants there can easily be a hundred 'avatar change' events over a weekend, for example, resulting in a very slow-to-open room on Monday morning.

@uhoreg uhoreg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P1 labels Apr 20, 2022
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 25, 2022
@su-ex
Merge tag 'v1.11.15' into sc
887be88 
* Make clear notifications work with threads ([\element-hq#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq#23751.
* Change "None" to "Off" in notification options ([\element-hq#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\element-hq#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\element-hq#9559](matrix-org/matrix-react-sdk#9559)).
* Improve design of the rich text editor ([\element-hq#9533](matrix-org/matrix-react-sdk#9533)). Contributed by @florianduros.
* Enable user to zoom beyond image size ([\element-hq#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\element-hq#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92.
* Make build scripts work on NixOS ([\element-hq#23740](element-hq#23740)).
* Fix integration manager `get_open_id_token` action and add E2E tests ([\element-hq#9520](matrix-org/matrix-react-sdk#9520)).
* Fix links being mangled by markdown processing ([\element-hq#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq#23743.
* Fix: inline links selecting radio button ([\element-hq#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92.
* Fix wrong error message in registration when phone number threepid is in use. ([\element-hq#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\element-hq#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq#23733.
* Fix read receipts trickling down correctly ([\element-hq#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq#23746.
* Resilience fix for homeserver without thread notification support ([\element-hq#9565](matrix-org/matrix-react-sdk#9565)).
* Don't switch to the home page needlessly after leaving a room ([\element-hq#9477](matrix-org/matrix-react-sdk#9477)).
* Differentiate download and decryption errors when showing images ([\element-hq#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\element-hq#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq#15610 and element-hq#10781.
* Fix TimelineReset handling when no room associated ([\element-hq#9553](matrix-org/matrix-react-sdk#9553)).
* Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq#23648.
* Fix `ThreadView` tests not using thread flag ([\element-hq#9547](matrix-org/matrix-react-sdk#9547)). Contributed by @MadLittleMods.
* Handle deletion of `m.call` events ([\element-hq#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq#23663.
* Fix incorrect notification count after leaving a room with notifications ([\element-hq#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-Read-Receipts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @kpfleming @cuibonobo @uhoreg @lampholder