-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 events (with slashes in them) break generated permalinks and cause you to lose your place in the timeline when forwarding events. #9520
Comments
I realized that events which have such issues are have slashes in their ids. |
I also reproduced that in events which have UPD: But it seems only when |
Thanks for the investigation @unclechu - you're right, these issues do seem to be cause on events with slashes (or perhaps +es) in them. I've updated the title to reflect that these are 'v3' events (my understanding is that event ids won't always be allowed to have slashes in them, but we have to fix riot to defend against them for current events. |
matrix-org/matrix-react-sdk#2827 should have fixed the general case of this, which is currently unreleased (in 1.1.0-rc.1). The other portion of this is highly related to https://github.com/vector-im/riot-web/issues/9424 / #9149 |
I think this is fixed by matrix-org/matrix-react-sdk#2827 - I can't reproduce it anymore. |
@turt2live When this fix is supposed to be delivered to stable Riot branch? Will this issue be marked with some tag then? |
It should have landed in 1.1.0 |
@turt2live Hmm... It seems it's already fixed in stable Riot branch (I mean |
Yes, that is 1.1.2 which includes 1.1.0 |
@turt2live Cool, thanks for fixing it! |
* Make clear notifications work with threads ([\element-hq#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq#23751. * Change "None" to "Off" in notification options ([\element-hq#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei. * Advanced audio processing settings ([\element-hq#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq#6278. Contributed by @MrAnno. * Add way to create a user notice via config.json ([\element-hq#9559](matrix-org/matrix-react-sdk#9559)). * Improve design of the rich text editor ([\element-hq#9533](matrix-org/matrix-react-sdk#9533)). Contributed by @florianduros. * Enable user to zoom beyond image size ([\element-hq#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v. * Fix: Move "Leave Space" option to the bottom of space context menu ([\element-hq#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92. * Make build scripts work on NixOS ([\element-hq#23740](element-hq#23740)). * Fix integration manager `get_open_id_token` action and add E2E tests ([\element-hq#9520](matrix-org/matrix-react-sdk#9520)). * Fix links being mangled by markdown processing ([\element-hq#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq#23743. * Fix: inline links selecting radio button ([\element-hq#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92. * Fix wrong error message in registration when phone number threepid is in use. ([\element-hq#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand. * Fix missing avatar for show current profiles ([\element-hq#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq#23733. * Fix read receipts trickling down correctly ([\element-hq#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq#23746. * Resilience fix for homeserver without thread notification support ([\element-hq#9565](matrix-org/matrix-react-sdk#9565)). * Don't switch to the home page needlessly after leaving a room ([\element-hq#9477](matrix-org/matrix-react-sdk#9477)). * Differentiate download and decryption errors when showing images ([\element-hq#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq#3892. * Close context menu when a modal is opened to prevent user getting stuck ([\element-hq#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq#15610 and element-hq#10781. * Fix TimelineReset handling when no room associated ([\element-hq#9553](matrix-org/matrix-react-sdk#9553)). * Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq#23648. * Fix `ThreadView` tests not using thread flag ([\element-hq#9547](matrix-org/matrix-react-sdk#9547)). Contributed by @MadLittleMods. * Handle deletion of `m.call` events ([\element-hq#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq#23663. * Fix incorrect notification count after leaving a room with notifications ([\element-hq#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
Forwarding many events from one room to another is messed up in Riot.
I can't just forward few events (in my case photos), like selecting few of them and forward them at once so I have to do it one by one, I'm feeling sick when I do it for 20 events for instance;
Very strange bug I tried to avoid but failed. When you forward an event from room A to room B you just go back to room A to forward next event in the list, but when you press forward on next event scroll falls down to the last event in the room, so now you're lost the last item you were trying to forward, so after a forward it to B you now have to go to room A and find that last forwarded event, so hard to not get tired;
As a possible way to avoid bug in pt. 2 I just imagined I could anchor on specific events. So what I was trying to do is clicking on current event I'm forwarding at the moment (clicking on time of event, on the left side) so I would have exact URI link in my browser history, forward an event and then just press "back" button in my browser, but it works only for one event, or sometimes somehow for few but always failing with error on screenshot:
Version information
The text was updated successfully, but these errors were encountered: