Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apk tools config #1140

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Remove apk tools config #1140

merged 7 commits into from
Jul 29, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the unused ApkToolsConfig class. In practice we are not using this so we should get rid of the complexity.

@fractalwrench fractalwrench requested a review from a team as a code owner July 26, 2024 09:07
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 92.07317% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (a7d76f3) to head (8e65ab6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   82.87%   82.88%   +0.01%     
==========================================
  Files         433      435       +2     
  Lines       11282    11284       +2     
  Branches     1755     1750       -5     
==========================================
+ Hits         9350     9353       +3     
- Misses       1151     1154       +3     
+ Partials      781      777       -4     
Files Coverage Δ
.../android/embracesdk/internal/InternalTracingApi.kt 100.00% <ø> (ø)
.../io/embrace/android/embracesdk/spans/TracingApi.kt 93.87% <ø> (ø)
...embrace/android/embracesdk/internal/IdGenerator.kt 100.00% <100.00%> (ø)
...acesdk/internal/arch/schema/AppTerminationCause.kt 100.00% <100.00%> (ø)
...bracesdk/internal/clock/NormalizedIntervalClock.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/clock/SystemClock.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/injection/InitModuleImpl.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/logging/EmbLoggerImpl.kt 64.70% <100.00%> (ø)
...bracesdk/internal/logs/EmbraceLogRecordExporter.kt 63.63% <100.00%> (ø)
...racesdk/internal/logs/EmbraceLogRecordProcessor.kt 100.00% <100.00%> (ø)
... and 50 more

... and 8 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH FINALLY!

@fractalwrench fractalwrench force-pushed the remove-apk-tools-config branch from f08cdc7 to d0d514c Compare July 29, 2024 09:21
@fractalwrench fractalwrench requested a review from fnewberg as a code owner July 29, 2024 09:22
@fractalwrench fractalwrench merged commit f477bc3 into master Jul 29, 2024
6 checks passed
@fractalwrench fractalwrench deleted the remove-apk-tools-config branch July 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants