-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI green again and remove Python 3.5 from CI #424
Conversation
Some other test dependencies bring in the released enable already. This means attempt to install the local source may not override the released copy.
Instead of installing the same releases of traits/traitsui/pyface twice, set the requirements for EDM. The installation for demo dependencies (see #386) was removed. They are not used for CI, and are rarely used for development. Installing demo dependencies brings in the released egg of enable, causing CI to stop testing local enable source.
It will need to die soon enough.
This reverts commit 4ae5903.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Haven't tested the changes to etstool locally though.
also fixes #410 |
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 32.73% 28.92% -3.82%
==========================================
Files 206 206
Lines 18297 18246 -51
Branches 2470 2466 -4
==========================================
- Hits 5990 5278 -712
- Misses 11929 12641 +712
+ Partials 378 327 -51
Continue to review full report at Codecov.
|
This PR's goal is to make CI green again.
Closes #423
Closes #410
I tried my best to limit the scope of this PR, but it was difficult to achieve 😂 .
In summary:
Details:
On this:
This is because many recent releases have not been built for EDM + Python 3.5 any more. Python 3.5 has already passed end-of-life (see #415 too). This step I can revert.