Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selection entity selection flag in KET format #3934

Closed
vanoprenko opened this issue Jan 18, 2024 · 2 comments · Fixed by #3966 or #4037
Closed

Support selection entity selection flag in KET format #3934

vanoprenko opened this issue Jan 18, 2024 · 2 comments · Fixed by #3966 or #4037
Assignees
@captain2b
Labels
query features phase II
Milestone
Ketcher 2.18.0-rc.4

Comments

@vanoprenko
Copy link
Collaborator

vanoprenko commented Jan 18, 2024 •
edited by captain2b
Loading

When converting a structure to KET format Ketcher should supply selection flag for each atom, bond or any other selectable entity.

The flag should be specified according to KET specification updated in scope of epam/Indigo#1589

Notes:
Selection should not be updated on 'add to canvas' action
@vanoprenko vanoprenko added this to the Query Features - Phase II milestone Jan 18, 2024
AliaksandrDziarkach pushed a commit that referenced this issue Jan 24, 2024
#3934 Support selection entity selection flag in KET format
9c169c6 
Update ket schema with new "selected" field for atoms and bonds.
captain2b pushed a commit that referenced this issue Jan 25, 2024
@captain2b
#3934 Support selection entity selection flag in KET format
649bb64 
Update ket schema with new "selected" field for atoms and bonds.
captain2b added a commit that referenced this issue Jan 25, 2024
@captain2b
#3934 Support selection entity selection flag in KET format WIP
fe0ce99
captain2b added a commit that referenced this issue Jan 26, 2024
@captain2b
#3934 Support selection entity selection flag in KET format fix
1d27f35
captain2b pushed a commit that referenced this issue Jan 26, 2024
@captain2b
#3934 Support selection entity selection flag in KET format
962e65d 
Update ket schema with new "selected" field for atoms and bonds.
captain2b added a commit that referenced this issue Jan 26, 2024
@captain2b
#3934 Support selection entity selection flag in KET format add selec…
cb233d6 
…ted property to atom and bond, populate struct with selection before server call
captain2b added a commit that referenced this issue Jan 26, 2024
@captain2b
#3934 Support selection entity selection flag in KET format update in…
5338a8c 
…digo
@captain2b captain2b linked a pull request Jan 30, 2024 that will close this issue
3934 Support selection entity selection flag in KET format #3966
Merged
9 tasks
captain2b added a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format WIP
3ace8c7
captain2b added a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format apply sel…
faf26f3 
…ection from indigo
captain2b pushed a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format
bd6c28e 
Update ket schema with new "selected" field for atoms and bonds.
captain2b added a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format add selec…
8cf0da1 
…ted property to atom and bond, populate struct with selection before server call
captain2b added a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format update in…
70a5720 
…digo
captain2b added a commit that referenced this issue Jan 30, 2024
@captain2b
#3934 Support selection entity selection flag in KET format apply sel…
01d26db 
…ection from indigo
captain2b pushed a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format
c3618f3 
Update ket schema with new "selected" field for atoms and bonds.
captain2b added a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format add selec…
9575100 
…ted property to atom and bond, populate struct with selection before server call
captain2b added a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format apply sel…
f235cd3 
…ection from indigo
captain2b added a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format add selec…
89283fb 
…tion for arrows,texts and pluses
captain2b added a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format add selec…
904be1e 
…tion for arrows,texts and pluses, rename property
captain2b added a commit that referenced this issue Jan 31, 2024
@captain2b
#3934 Support selection entity selection flag in KET format small fixes
9b668a9
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
568fcd8 
…t small fix
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
d373637 
…t small fix
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
029500f 
…t restrict access to initiallySelected fields
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
6f7f354 
…t update snaps
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
9c93f92 
…t fix RGroupAttachmentPoint selection
captain2b added a commit that referenced this issue Feb 6, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
c6d9124 
…t fix some selection cases
@captain2b captain2b linked a pull request Feb 6, 2024 that will close this issue
Backmerge: 3934 Support selection entity selection flag in KET format #4037
Merged
captain2b pushed a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET format
b55cb18 
Update ket schema with new "selected" field for atoms and bonds.
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
3c20d7e 
…t add selection for atoms, bonds, arrows, texts and pluses
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
f630616 
…t preserve selection on save / load file
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
37f6bda 
…t update snapshots
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
af26ad2 
…t small fix
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
bffa275 
…t small fix
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
6ba9e3f 
…t restrict access to initiallySelected fields
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
e8bf4a2 
…t update snaps
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
b44c465 
…t fix RGroupAttachmentPoint selection
captain2b added a commit that referenced this issue Feb 7, 2024
@captain2b
Backmerge: #3934 Support selection entity selection flag in KET forma…
feb38e8 
…t fix some selection cases
This was referenced Feb 7, 2024
Closed
Open
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 7, 2024 •
edited
Loading

Tested. The selection remains on the structure. But not on Simple Objects, Plus sign, Reactions arrows, Text. Relevant tasks will be created.

This was referenced Feb 7, 2024
Open
Closed
Closed
Closed
Closed
Open
Open
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 2.18.0-rc.4 Build at 2024-02-06; 13:45:28
  • Indigo Toolkit Version 1.18.0-rc.6.0-g98bf384e0-x86_64-linux-gnu-11.2.1

@AlexeyGirin AlexeyGirin mentioned this issue Mar 13, 2024
Closed
rrodionov91 added a commit that referenced this issue Apr 17, 2024
@rrodionov91
Merge pull request #3947 from epam/feature/3934-add-selected-to-atoms…
b0f02b8 
…-and-bonds-in-ket-schema

 #3934 Support selection entity selection flag in KET format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@captain2b captain2b

Labels
query features phase II
Projects
None yet
Milestone
Ketcher 2.18.0-rc.4
5 participants
@captain2b @rrodionov91 @vanoprenko @AlexeyGirin @Zhirnoff