Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic chains disappear from canvas when try to Edit in the sequence mode #4548

Closed
NadezhdaPeskun opened this issue Apr 29, 2024 · 3 comments · Fixed by #4609 or #4612
Closed

Cyclic chains disappear from canvas when try to Edit in the sequence mode #4548

NadezhdaPeskun opened this issue Apr 29, 2024 · 3 comments · Fixed by #4609 or #4612
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.21.0-rc.3

Comments

@NadezhdaPeskun
Copy link

NadezhdaPeskun commented Apr 29, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode

  2. Open file with Cyclic Chain
    ketcher.zip

  3. Switch to sequence mode

image
  1. Select any T >> context menu >> Edit
image
  1. Try to add latest any letter (A)
image

Actual behavior
Cyclic bond is moved to the next latest place.
All chains disappear from canvas when try to add new letter to latest place in the sequence mode

Expected behavior
Cyclic chains should not disappear from canvas when Edit in the sequence mode.

Attachment:

2024-04-29_11h19_29.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Version
Ketcher Version 2.20.0-rc.3 Build at 2024-04-26; 16:57:15
Indigo Toolkit Version 1.19.0-rc.3.0-gf2d7689b8-wasm32-wasm-clang-12.0.0
@NadezhdaPeskun NadezhdaPeskun added this to the Ketcher 2.21.0-rc.2 milestone Apr 29, 2024
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned tmrr13 May 10, 2024
rrodionov91 added a commit that referenced this issue May 10, 2024
@rrodionov91
#4548 - Cyclic chains disappear from canvas when try to Edit in the s…
4f2d13d 
…equence mode

- used lastNonEmptyNode instead of lastNode for cyclic chain end bond render
rrodionov91 added a commit that referenced this issue May 10, 2024
@rrodionov91
#4548 - Cyclic chains disappear from canvas when try to Edit in the s…
21c0b2d 
…equence mode

- used lastNonEmptyNode instead of lastNode for cyclic chain end bond render
@rrodionov91 rrodionov91 linked a pull request May 10, 2024 that will close this issue
#4548 - Cyclic chains disappear from canvas when try to Edit in the sequence mode #4609
Merged
9 tasks
rrodionov91 added a commit that referenced this issue May 13, 2024
@rrodionov91 @baranovdv
#4548 - Cyclic chains disappear from canvas when try to Edit in the s…
bb5239a 
…equence mode (#4609)

- used lastNonEmptyNode instead of lastNode for cyclic chain end bond render

Co-authored-by: Dmitry Baranov <baranov.d.v.1988@gmail.com>
rrodionov91 added a commit that referenced this issue May 13, 2024
@rrodionov91
#4548 - Cyclic chains disappear from canvas when try to Edit in the s…
c586945 
…equence mode

- used lastNonEmptyNode instead of lastNode for cyclic chain end bond render
@rrodionov91 rrodionov91 linked a pull request May 13, 2024 that will close this issue
Backmerge: #4548 - Cyclic chains disappear from canvas when try to Edit in the sequence mode #4612
Merged
9 tasks
rrodionov91 added a commit that referenced this issue May 13, 2024
@rrodionov91
Backmerge: #4548 - Cyclic chains disappear from canvas when try to Ed…
6dbcb64 
…it in the sequence mode (#4612)
@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue May 28, 2024
Closed
@ViktoriaTkacheva
Copy link
Collaborator

An issue, found while testing this bug fix, was moved to a separate ticket: #4706

@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue May 29, 2024
Closed
@NadezhdaPeskun
Copy link
Author

NadezhdaPeskun commented May 29, 2024 •
edited
Loading

Verified as fixed for CI 2.22 rc1 - new bugs are added

@Zhirnoff
Copy link
Collaborator

2024-06-10_14h43_17

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.3]
Indigo version
[Version 1.20.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.21.0-rc.3
6 participants
@rrodionov91 @tmrr13 @Zhirnoff @ViktoriaTkacheva @ilya-asiyuk-epam @NadezhdaPeskun