Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: A new nucleotide should not be added to the end of a cyclic sequence, if the last nucleotide of the sequence does not have a free AP R1 or R2 #4706

Closed
ViktoriaTkacheva opened this issue May 28, 2024 · 3 comments · Fixed by #4703
Labels

Comments

@ViktoriaTkacheva
Copy link
Collaborator

ViktoriaTkacheva commented May 28, 2024

Steps to Reproduce

  1. Switch to the Macro mode

  2. Draw a cyclic sequence, consisting of any 4 nucleotides, for example:

    image
  3. Switch to the Sequence mode - the Text-editing mode

    image
  4. Add any nucleotide to the end of this sequence

  5. Switch to the Flex mode and move all nucleotides apart from each other so that all bonds are visible

Actual behavior
A new nucleotide is added to the end of a cyclic sequence. The bond, that provided and displayed cyclicity, disappears in the Sequence mode and the Flex mode
image
image

Expected behavior
A new nucleotide should not be added to the end of a cyclic sequence, if the last nucleotide of the sequence does not have a free AP R1 or R2. An error message appears on the canvas (From BA):

Error Message:
It is impossible to merge fragments. Attachment point to establish bonds are not available.

Screenshots

2024-05-28_19h34_16.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (125.0.6422.61) x64

Ketcher version 2.21.0-rc.2, Build at 2024-05-28; 14:29:04

related with

@NadezhdaPeskun
Copy link

NadezhdaPeskun commented Jun 3, 2024

Should be verified with next Issues: (#4708, #4575, #4506, #4706) + #4328
Error Message should appear:
Error Message:
It is impossible to merge fragments. Attachment point to establish bonds are not available.

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 4, 2024

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 1, 2024

Automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants