#4575 - New Sequences are created while we add cyclic to middle of sequence. #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guch1g0v
changed the title
This was
linked to
issues
May 29, 2024
svvald
approved these changes
May 31, 2024
| @@ -883,6 +941,14 @@ export class SequenceMode extends BaseMode { | |||
| return modelChanges; | |||
| } | |||
|
|
|||
| private showMergeWarningModal(editor: CoreEditor) { | |||
There was a problem hiding this comment.
I think it's rather an error than a warning message (which I covered by a pop-up in the bottom of the editor but doesn't block it)
| ); | ||
| } | ||
| if (isPasteInStart) { | ||
| return this.isR2Free(lastNodeOfNewFragment) && this.isR1Free(currentNode); |
There was a problem hiding this comment.
If you need to check both R1 and R2 when pasting into start or end of sequence, you may probably use areR1R2Free here rather than separate functions
svvald
deleted the
4575-new-sequences-are-created-while-we-add-cyclic-to-middle-of-sequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
#1234 – issue name