#2742 [Part 1] Refactor R-Group attachment points as entities #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleicul
changed the title
yuleicul
force-pushed
the
2742/part-1/refactor-into-entity
branch
2 times, most recently
from
9481588 to
009769f
Compare
8 tasks
This was referenced Jul 26, 2023
|
Merged by #2978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of the small PRs to resolve #2742 for easy review.
This PR is open for reviews but please do not merge it.
What is done in this PR?
Refactors R-Group attachment point into entity "RGroupAttachmentPoint" and render object "ReRGroupAttachmentPoint", and adds related operations and actions.
How is it refactored?
What is NOT done in this PR?
Two todos and one bug needs to be fixed in other small PRs.
Check list
#1234 – issue name