#2742 [Part 2] Allow to hover on or select R-Group attachment points #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] Proposal to enhance R-Group attachment point selection
Notice that the following code needs to be refactored in the scope of this enhancement // packages/ketcher-core/src/application/render/restruct/rergroup.js
calcBBox(render) {
// ...
const rGroupAttachmentPointsVBox =
render.ctab.getRGroupAttachmentPointsVBoxByAtomIds(this.getAtoms(render));
if (rGroupBoundingBox && rGroupAttachmentPointsVBox) {
rGroupBoundingBox = Box2Abs.union(
rGroupBoundingBox,
rGroupAttachmentPointsVBox,
);
}
// ...
}
|
yuleicul
requested review from
kaluginserg and
StarlaStarla
and removed request for
Nitvex and
SashaGraves
kaluginserg
reviewed
Jul 25, 2023
| @@ -610,6 +610,16 @@ export class SGroup { | |||
| return bonds; | |||
| } | |||
|
|
|||
| getRGroupAttachmentPoints(molecule: Struct) { | |||
There was a problem hiding this comment.
Curious, is the function used somewhere?
There was a problem hiding this comment.
Forgot to remove it, thank you!
kaluginserg
reviewed
Jul 25, 2023
| const atomId = reItem.item.atomId; | ||
| const atom = this.molecule.atoms.get(atomId); | ||
| assert(atom != null); | ||
| return !FunctionalGroup.isAtomInContractedFunctionalGroup( |
There was a problem hiding this comment.
functional group is subset of the sgroup, so just curious why we checking only the functional groups in this fucntion, but not any sgroup?
There was a problem hiding this comment.
Sorry, I think I don't really get your question, but this function is to get R-Group attachment points that are outside of contracted functional groups, does it make sense?
SashaGraves
reviewed
Jul 26, 2023
packages/ketcher-core/src/application/editor/actions/rgroupAttachmentPoint.ts
Show resolved
Hide resolved
13 tasks
SashaGraves
approved these changes
Jul 27, 2023
|
Merged with #2978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of the small PRs to resolve #2742 for easy review.
This PR is open for reviews but please do not merge it.
What is done in this PR?
Allow to hover on attachment points using Select Tool or R-Group Attachment Point Tool
Allow to select attachment points using Select Tool
Fix Attachment points should be within R-Group brackets #197 which was broken by the previous small PR #2742 [Part 1] Refactor R-Group attachment points as entities #2928
Check list
#1234 – issue name