Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2742 - Attachment point selection edition and deletion #2978

Merged
merged 15 commits into from
Aug 1, 2023

Conversation

yuleicul
Copy link
Collaborator

@yuleicul yuleicul commented Jul 27, 2023

Closes #2742

This PR has been divided into 5 small PRs in order to ease code reviews.
This PR can be merged after all 5 PRs are approved, and then the 5 small PRs will be closed.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"

@yuleicul yuleicul linked an issue Jul 27, 2023 that may be closed by this pull request
@rrodionov91
Copy link
Collaborator

Also please check how it works with this change #2977 .

@yuleicul yuleicul force-pushed the 2742-attachment-point-selection-edition-and-deletion branch from 01f441c to 32cbcdf Compare July 31, 2023 07:02
@yuleicul
Copy link
Collaborator Author

@rrodionov91 really appreciate your detailed review!

@MartaWilliams
Copy link
Collaborator

Tests fail

ad. 3 - it's possible to remove the attachment point after selecting it and pressing Del hotkey or clicking the right mouse key, But after selecting the attachment and choosing Erase /scissors from the Top bar menu nothing is happening

ad.4 Editing existing attachments is not working - clicking the right mouse is giving only the "remove". According to AC should be possible to adit a type of attachment point (Choosing Primary/Secondary or both)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachment point selection edition and deletion
4 participants