-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2742 - Attachment point selection edition and deletion #2978
#2742 - Attachment point selection edition and deletion #2978
Conversation
packages/ketcher-core/src/application/editor/actions/rgroupAttachmentPoint.ts
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/actions/rgroupAttachmentPoint.ts
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/actions/rgroupAttachmentPoint.ts
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/actions/rgroupAttachmentPoint.ts
Show resolved
Hide resolved
packages/ketcher-core/src/application/editor/operations/OperationType.ts
Show resolved
Hide resolved
...her-core/src/application/editor/operations/rgroupAttachmentPoint/RGroupAttachmentPointAdd.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-core/src/application/render/restruct/reatom.ts
Outdated
Show resolved
Hide resolved
Also please check how it works with this change #2977 . |
01f441c
to
32cbcdf
Compare
@rrodionov91 really appreciate your detailed review! |
…d-deletion Resolve conflicts with #3003
Tests fail ad. 3 - it's possible to remove the attachment point after selecting it and pressing Del hotkey or clicking the right mouse key, But after selecting the attachment and choosing Erase /scissors from the Top bar menu nothing is happening ad.4 Editing existing attachments is not working - clicking the right mouse is giving only the "remove". According to AC should be possible to adit a type of attachment point (Choosing Primary/Secondary or both) |
Closes #2742
This PR has been divided into 5 small PRs in order to ease code reviews.
This PR can be merged after all 5 PRs are approved, and then the 5 small PRs will be closed.
InfoPanel
#2969Check list
#1234 – issue name