This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update frontend libs #497
Merged
Update frontend libs #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-localstorage writes its data to the local file system, which is a bit of a pain. In particular, we were loading `.`, which meant that if we cleared the storage, we'd delete everything in the current directory. dom-storage is a bit more widely used and can live in memory.
We'll probably want to switch to the 3.X line, but I didn't want to make that potentially breaking change now. 1.12.4's version of :visible doesn't work with DOM elements that aren't attached (including those of jsdom), so some tests needed to be tweaked to avoid that.
This adds a shrinkwrap file to pin the frontend dependencies (and their dependencies) to specific versions. While the Python site of -site is used primarily as a library, the JS side is a single application.
theresaanna
approved these changes
Aug 26, 2017
|
Thanks @theresaanna ! |
cmc333333
pushed a commit
that referenced
this pull request
Aug 29, 2017
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers.
cmc333333
pushed a commit
that referenced
this pull request
Aug 30, 2017
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers. * #506 Replaced "orange" values with their "gold" equivalents
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @theresaanna's branch to update several of the JS libs. It doesn't resolve the jQuery version problem, but does add a shrinkwrap file to ensure our dependencies stay still.