This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add the text of the link to the aria-label. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, screen readers would only read "Link opens in a new window" without the link's text.
|
Thanks @micahtaylor! Rebasing to fix the travis error, then I'll merge. |
cmc333333
force-pushed
the
516-external-links
branch
from
1493f73
to
07f62c0
Compare
cmc333333
pushed a commit
that referenced
this pull request
Aug 29, 2017
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers.
cmc333333
pushed a commit
that referenced
this pull request
Aug 30, 2017
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers. * #506 Replaced "orange" values with their "gold" equivalents
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, screen readers would only read "Link opens in a new window"
without the link's text.