This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Rework "Effective date" UI #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 29, 2017 18:26
We had been throwing around pseudo-constants "past" "current" and "future". This converts them into an enum and renames "current" to "present" to disambiguate.
cmc333333
force-pushed
the
510-effective-date
branch
from
a08219a
to
4bfe8f2
Compare
tadhg-ohiggins
approved these changes
Aug 29, 2017
added 2 commits
August 29, 2017 19:10
We had been passing only the effective date of a version, but the new design calls for both a start end end date.
The "Effective" heading hasn't been obvious enough to users, particularly when reviewing previous versions of the regulation. These template and style tweaks change that by adding the end date where applicable and highlighting the version when it's not the current law.
cmc333333
force-pushed
the
510-effective-date
branch
from
4bfe8f2
to
c85e528
Compare
|
Thanks @tadhg-ohiggins -- I'm going to fix the lint error, bump the version, then merge. |
cmc333333
pushed a commit
that referenced
this pull request
Aug 29, 2017
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers.
micahtaylor
reviewed
Aug 29, 2017
| @@ -57,6 +57,7 @@ $panel_text_color: $black; // Text color for table of contents | |||
| $text_highlight_color: $green_lightest; // Text highlight used for diffs | |||
| $success_color: $green_lightest; // Used as background for success messages | |||
| $notice_color: $blue_lightest; // Used as background for neutral notice messages | |||
| $alert_color: $orange_lightest; // Used as background for caution messages | |||
There was a problem hiding this comment.
Would like this to be #fff0dd similar to the CFPB lightest orange, please.
There was a problem hiding this comment.
I think it's fine to change it to the originating $orange_lightest; declaration.
There was a problem hiding this comment.
What do you think about using the "gold" color scheme from the USDWS (eRegs' base should be following those color schemes, but it may have moved out from under us)? We'd be at #fff1d2 then.
There was a problem hiding this comment.
Closing the loop, @micahtaylor said this was a reasonable solution.
micahtaylor
reviewed
Aug 29, 2017
| @@ -107,7 +107,7 @@ | |||
| position: fixed; | |||
| top: $mainhead_height; | |||
| min-width: 100%; | |||
| background: $panel_background_color; | |||
| background-color: $panel_background_color; | |||
| color: $black; | |||
There was a problem hiding this comment.
The font color should be $atf_sub_head_background, what was the background color. I think that is declared here but not sure.
There was a problem hiding this comment.
That'll be an ATF-specific override. The default sub-head is black(ish) on gray, as in the screenshots.
added 2 commits
August 30, 2017 10:07
USWDS doesn't have an orange color, so we'll want to remove it eventually. In the short term, though, we'll deprecate its usage. We can remove with the next major release.
New Features * #506 "Effective date" UI now includes more information and warns when not viewing the current version. Bug Fixes & Misc * #497 Update frontend dependencies. * #501 Set Sauce Labs key in Travis UI. * #502 Improve accessibility by including the text of a link in its aria-label. * #503 Fix some HTML escaping issues. * #504 Fix scrolling issue in regulation timeline. * #505 Darken Subpart labels to provide more contrast. Remove ids from SVGs for automated readers. * #506 Replaced "orange" values with their "gold" equivalents
cmc333333
force-pushed
the
510-effective-date
branch
from
2a05c25
to
7c7f8ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 18F/atf-eregs#510, the display of the effective date in the upper-right has confused users. In particular, they weren't confident which version they were viewing when seeing previous versions. This resolves some of that. @micahtaylor's already approved the design.
Current law
Past/Future law