Bytecode report presets #14350
Merged
Bytecode report presets #14350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
previously approved these changes
Jun 23, 2023
cameel
force-pushed
the
bytecode-report-presets
branch
from
07e7fd7
to
10670d6
Compare
matheusaaguiar
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #13583.
Currently the bytecode report generation is hard-coded to output results of unoptimized and then optimized compilation. This PR organizes these these settings into distinct presets and adds command-line flags for selecting an arbitrary subset of those presets.
In subsequent PRs I'll use this mechanism to add via IR presets. This PR is a pure refactor that does not change behavior and preserves the default behavior of the scripts (since they're also used for PR checks in solc-bin).
The mechanism will also later be used to generate reports for all presets in parallel in CI.
Note that there are many whitespace-only changes in the JS script. I recommend turning on the mode that ignores whitespace changes.