Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize optimized and unoptimized bytecode reports in CI #14354

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

cameel
Copy link
Member

@cameel cameel commented Jun 23, 2023

Depends on #14353. Merged.
Closes #13056.

This is the second step in parallelizing the bytecode report generation, after #14330. Now that I can generate optimized and unoptimized report separately via presets (#14350), I'm doing just that, in parallel.

This time using CircleCI's job matrix rather than circleci tests split utility. The downside is that it doubles the number of jobs. The upside is that it's simpler.

@cameel cameel added testing 🔨 has dependencies The PR depends on other PRs that must be merged first labels Jun 23, 2023
@cameel cameel self-assigned this Jun 23, 2023
@cameel
Copy link
Member Author

cameel commented Jun 23, 2023

I adjusted the repo settings to make the b_bytecode_* jobs not required. Without it, this PR would not be mergeable.

Note that t_bytecode_compare is still required and depends on all those jobs, so a PR that fails to generate any of the reports won't pass required checks anyway.

@cameel
Copy link
Member Author

cameel commented Jun 23, 2023

Here's the timing on develop vs this PR:

Before (develop)

Job duration
b_bytecode_win 11m 24s
b_bytecode_osx 6m 8s
b_bytecode_ems 7m 21s
b_bytecode_ubu_static 2m 57s
b_bytecode_ubu 5m 51s

After (this PR)

Job duration
b_bytecode_win-legacy-optimize 6m 45s
b_bytecode_win-legacy-no-optimize 4m 46s
b_bytecode_osx-legacy-optimize 4m 13s
b_bytecode_osx-legacy-no-optimize 3m 8s
b_bytecode_ems-legacy-optimize 5m 2s
b_bytecode_ems-legacy-no-optimize 2m 8s
b_bytecode_ubu_static-legacy-optimize 2m 22s
b_bytecode_ubu_static-legacy-no-optimize 1m 18s
b_bytecode_ubu-legacy-optimize 3m 52s
b_bytecode_ubu-legacy-no-optimize 2m 48s

Base automatically changed from unify-and-simplify-bytecode-report-generation-in-ci to develop June 26, 2023 08:50
@cameel cameel force-pushed the parallelize-bytecode-compare-presets branch from 8a3963c to 92816eb Compare June 26, 2023 08:53
@cameel cameel marked this pull request as ready for review June 26, 2023 08:54
@ekpyron ekpyron merged commit 1067232 into develop Jun 26, 2023
1 check passed
@ekpyron ekpyron deleted the parallelize-bytecode-compare-presets branch June 26, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first testing 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize bytecode report generation in CI
2 participants