Unify and simplify bytecode report generation in CI #14353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
unify-and-simplify-bytecode-report-generation-in-ci
branch
from
d8a4673
to
9467b4b
Compare
…new script and use it for all platforms in CI
cameel
force-pushed
the
unify-and-simplify-bytecode-report-generation-in-ci
branch
from
9467b4b
to
45c2ffc
Compare
matheusaaguiar
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another prerequisite for #13583.
The PR merges the existing
storebytecode.shscript (of which only the JS part was still in use) with the parallel report generation I added in #14330. Then it extracts the report comparison logic into a script as well. They're both no longer a bunch of one-liners and are better off as scripts. I will need to complicate them even more in upcoming PRs to support the presets I'm adding in #14350.Just like #14350 this is a refactor and does not change behavior other than in trivial ways, like slightly altering the console output.