-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the mise script #170
Conversation
It's helpful to add an estimation about the time to finish running it locally each time more tasks are added to it. |
Print time duration in the end. |
I guess what @zhiqiangxu meant is to include a comment specifying the approximate time each added task will take to complete on a local machine? |
I mean adding a description in the PR about the incremented time and total time to run the task on local machine, we'll have to keep an eye on it to avoid it suddenly takes too much time. |
It makes more sense to check the real execution time locally in person due to different hardware conditions. |
It doesn't need to be accurate, just a baseline we have in mind. If the reviewee doesn't provide such numbers, all other reviewers will need to do it, which means duplicated work is done multiple times. |
The following newly added checks take less than 5 seconds each:
The full tests run about 18 minutes on AX101, and take approximately 11 hours on my local MacBook Pro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The mise script runs successfully on my machine. |
Add
semgrep
tests for code static analysis. These tests were missing in local tests compared to CircleCI's main workflow.Additionally, put the lint check early before solidity building. This step helps identify common format errors and can be completed quickly.
Other changes: