forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: fix semgrep-scan-local/UpgradeAnchorStateRegistry.s.sol #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/contracts-bedrock/scripts/deploy/UpgradeAnchorStateRegistry.s.sol
Outdated
Show resolved
Hide resolved
dajuguan
reviewed
Jan 21, 2025
packages/contracts-bedrock/scripts/deploy/UpgradeAnchorStateRegistry.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/deploy/UpgradeAnchorStateRegistry.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/deploy/UpgradeAnchorStateRegistry.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/deploy/UpgradeAnchorStateRegistry.s.sol
Outdated
Show resolved
Hide resolved
blockchaindevsh
approved these changes
Jan 24, 2025
qzhodl
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error log can be found here.
The fixes are based on the following
semgrep
rules:Fast command to reproduce the issue and verify the fix:
The reason why the errors are not detected early in the local environment is that the tests were missing from the
mise
script. Fixed in this PR.