Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: fix semgrep-scan-local/UpgradeAnchorStateRegistry.s.sol #171

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

syntrust
Copy link

The error log can be found here.

The fixes are based on the following semgrep rules:

  1. _args parameter should be wrapped with DeployUtils.encodeConstructor
  2. Use abi.encodeCall instead of abi.encodeWithSelector
  3. Named inputs to functions must be prepended with an underscore

Fast command to reproduce the issue and verify the fix:

just semgrep

The reason why the errors are not detected early in the local environment is that the tests were missing from the mise script. Fixed in this PR.

@syntrust syntrust merged commit 5355c23 into op-es Jan 24, 2025
@syntrust syntrust deleted the dl/fixcc/22 branch January 24, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants