Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enu frame #126

Merged
merged 16 commits into from
Nov 15, 2019
Merged

Feature/enu frame #126

merged 16 commits into from
Nov 15, 2019

Conversation

rikba
Copy link
Collaborator

@rikba rikba commented Nov 12, 2019

One approach to publish a position in ENU frame. Does not implement enu with covariance, yet.

  • Every receiver owns a geotf handler
  • This geotf handler has an ENU frame that can be set through a service either
    • To a defined position
    • To the current position
    • To the base station position (not tested)

#125 and ethz-asl/geodetic_utils#40 should be merged first. Addresses ENU publishing in #102.

@rikba
Copy link
Collaborator Author

rikba commented Nov 15, 2019

Ready to review @michaelpantic

geotf_.initFromRosParam();
if (geotf_.hasFrame("enu")) reset_position_ = ResetEnuOrigin::kNo;
geotf_.addFrameByEPSG("ecef", 4978);
geotf_.addFrameByEPSG("wgs84", 4326);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this is likely to happen, but could lead to confusion - what would happen if someone configures some other frame as 4978 as ecef in the rosparams? then this would fail and return weird results.

Maybe we could check return value of addFrameByEPSG (https://github.com/ethz-asl/geodetic_utils/blob/master/geotf/src/geodetic_converter.cc#L90), it gives false if the frame is already defined and output an error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

michaelpantic
michaelpantic previously approved these changes Nov 15, 2019
Copy link
Member

@michaelpantic michaelpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about frame definitions (not so important but could be confusing if it ever happens, as some frames have multiple definitions, e.g. there are different ECEF frames)

otherwise great !!

@rikba rikba merged commit b65adb5 into master Nov 15, 2019
@rikba rikba deleted the feature/enu_frame branch November 15, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants