add option to manually input forcal length #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBern
suggested changes
Oct 4, 2019
aslam_cv/aslam_cameras/include/aslam/cameras/implementation/PinholeProjection.hpp
Outdated
Show resolved
Hide resolved
aslam_cv/aslam_cameras/include/aslam/cameras/implementation/PinholeProjection.hpp
Outdated
Show resolved
Hide resolved
aslam_cv/aslam_cameras/include/aslam/cameras/implementation/PinholeProjection.hpp
Outdated
Show resolved
Hide resolved
aslam_cv/aslam_cameras/include/aslam/cameras/implementation/PinholeProjection.hpp
Show resolved
Hide resolved
floriantschopp
added a commit
that referenced
this pull request
Feb 3, 2020
…ocal_length_guess"" This reverts commit aac34c2.
floriantschopp
added a commit
that referenced
this pull request
Feb 3, 2020
* switch to PIL library for Image * deactivate threading for cv image displays * Update MulticamGraph.py Preserve some backward compatibility with older python versions. * fix opencv windows * add option to manually input forcal length * remove debug option * PR review @LBern * switch to double in the first place * Revert "Merge pull request #304 from ethz-asl/feature/input_focal_length_guess" This reverts commit 2999e18, reversing changes made to ee2b09d. Co-authored-by: Hannes Sommer <hannes.sommer@enlightware.ch>
floriantschopp
added a commit
that referenced
this pull request
Feb 9, 2020
* switch to PIL library for Image * deactivate threading for cv image displays * Update MulticamGraph.py Preserve some backward compatibility with older python versions. * fix opencv windows * add option to manually input forcal length * remove debug option * PR review @LBern * switch to double in the first place * Revert "Merge pull request #304 from ethz-asl/feature/input_focal_length_guess" This reverts commit 2999e18, reversing changes made to ee2b09d. * Revert "Revert "Merge pull request #304 from ethz-asl/feature/input_focal_length_guess"" This reverts commit aac34c2. * move comment and fix indentation * revive compatibility for scripted usage Co-authored-by: Hannes Sommer <hannes.sommer@enlightware.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.