feat(eslint-config-react-app): support ESLint 8.x

[MichaelDeBoey]

ESLint v8.0.0 is released 🎉

Dependencies should be compatible with ESLint 8 too before we can merge this one:

• @babel/eslint-parser (Support ESLint 8.x babel/babel#13712)
  • Add ESLint 8 support to @babel/eslint-parser babel/babel#13782
  • v7.16.0
• @rushstack/eslint-patch (Support ESLint 8.x microsoft/rushstack#2890)
  • [eslint-patch] Add support for ESLint 8.x microsoft/rushstack#2965
  • v1.0.8
• @typescript-eslint/eslint-plugin (Support for ESLint v8 typescript-eslint/typescript-eslint#3738)
  • feat: support ESLint v8 typescript-eslint/typescript-eslint#3737
  • chore: bump Node to ESLint 8.0 ranges typescript-eslint/typescript-eslint#3767
  • feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 typescript-eslint/typescript-eslint#3768
  • feat: remove meta.docs.category from rules typescript-eslint/typescript-eslint#3800
  • feat: align class property representation with ESTree typescript-eslint/typescript-eslint#3806
  • feat: support PrivateIdentifier typescript-eslint/typescript-eslint#3808
  • feat(eslint-plugin): update recommended configs typescript-eslint/typescript-eslint#3809
  • v5.0.0
• @typescript-eslint/parser (Support for ESLint v8 typescript-eslint/typescript-eslint#3738)
  • feat: support ESLint v8 typescript-eslint/typescript-eslint#3737
  • chore: bump Node to ESLint 8.0 ranges typescript-eslint/typescript-eslint#3767
  • feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 typescript-eslint/typescript-eslint#3768
  • feat: remove meta.docs.category from rules typescript-eslint/typescript-eslint#3800
  • feat: align class property representation with ESTree typescript-eslint/typescript-eslint#3806
  • feat: support PrivateIdentifier typescript-eslint/typescript-eslint#3808
  • feat(eslint-plugin): update recommended configs typescript-eslint/typescript-eslint#3809
  • v5.0.0
• eslint-plugin-flowtype (Support ESLint 8.x gajus/eslint-plugin-flowtype#495)
  • gajus/eslint-plugin-flowtype@05c3ae1
  • v8.0.0
• eslint-plugin-import (Support ESLint 8.x import-js/eslint-plugin-import#2211)
  • [New] Support for ESLint v8 import-js/eslint-plugin-import#2191
  • v2.25.0
• eslint-plugin-jest (Support ESLint 8.x jest-community/eslint-plugin-jest#881)
  • fix: stop testing on Node 10 and 15 jest-community/eslint-plugin-jest#891
  • fix: stop testing ESLint 5 jest-community/eslint-plugin-jest#893
  • fix: mark rules that suggest fixes with hasSuggestion for ESLint v8 jest-community/eslint-plugin-jest#898
  • fix: use correct property hasSuggestions rather than hasSuggestion jest-community/eslint-plugin-jest#899
  • feat: support eslint@8 jest-community/eslint-plugin-jest#940
  • fix: update @typescript-eslint/experimental-utils to v5 jest-community/eslint-plugin-jest#941
  • fix: support @typescript-eslint/eslint-plugin@5 jest-community/eslint-plugin-jest#942
  • v24.4.1
  • v24.4.2
  • v25.0.0
  • v25.0.4
  • v25.0.5
  • v25.1.0
• eslint-plugin-jsx-a11y (Support ESLint 8.x jsx-eslint/eslint-plugin-jsx-a11y#809)
  • [New] support ESLint 8.x jsx-eslint/eslint-plugin-jsx-a11y#810
  • v6.5.0
• eslint-plugin-react (Support ESLint 8.x jsx-eslint/eslint-plugin-react#3055)
  • [New] support eslint 8.x jsx-eslint/eslint-plugin-react#3059
  • v7.27.0
• eslint-plugin-react-hooks ([eslint-plugin-react-hooks] Support ESLint 8.x react#22246)
  • feat(eslint-plugin-react-hooks): support ESLint 8.x react#22248
  • v4.3.0
• eslint-plugin-testing-library (Support ESLint 8.x testing-library/eslint-plugin-testing-library#462)
  • chore: bump supported node version testing-library/eslint-plugin-testing-library#463
  • feat: support ESLint 8.x testing-library/eslint-plugin-testing-library#465
  • v5.0.0

Dependencies for react-scripts should be compatible with ESLint 8 too before we can merge this one:

• eslint-webpack-plugin (Support ESLint 8.x webpack-contrib/eslint-webpack-plugin#118)
  • feat: support eslint 8 webpack-contrib/eslint-webpack-plugin#121
  • v3.1.0

---

Closes #11374

BREAKING CHANGE: Requires ESLint@^8.0.0

[ahummel25]

Any timeline for this getting fixed/merged now that eslint v8 is live?

[MichaelDeBoey]

@ahummel25 As you can see in the OP, not all dependencies are updated for ESLint 8.x (yet), so we'll have to wait for them first.

[karlhorky]

@MichaelDeBoey should jest-community/eslint-plugin-jest#940 be added to the eslint-plugin-jest list above? It seems like this was just merged?

This was released in a minor (25.1.0): https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.1.0

[ianldgs]

Friendly ping: I think everything is merged now!

[MichaelDeBoey]

@ianldgs I'll update the PR whenever I have some time 👍

[dannyphillips]

Any update on when we plan to merge/release this?

[raix]

@MichaelDeBoey seems like some tests are still failing - I could not find any relations in the eslint release notes but we could try to update to 8.3.0 and see if that fixes anything - if not we'll have to take a closer look cc. @iansu @mrmckeb

[raix]

Actually the main branch seems to be failing in node 16/mac os on the same test "uses yarn as the package manager" - Will have to investigate

[GoetzGoerisch]

@raix looks like a timeout only problem for me.
The PR integration tests run fine on our fork. umati#1

[mrmckeb]

@MichaelDeBoey, this is great - thanks. We'd like to merge this in, but it looks like there are some dependency updates.

If you can take a look, that would be great. Otherwise I can jump in and help!

It might also be worth bumping to ESLint 8.3.0 (and spot check the other versions).

[raix]

Tests should be fixed on main now 🤞

[GoetzGoerisch]

@MichaelDeBoey rebased and updated branch here: https://github.com/umati/create-react-app/tree/eslint-8 please integrate if you like.

[MichaelDeBoey]

@mrmckeb I've rebase this onto main and updated all ESLint related packages to their latest version, so I think this one is good to be merged now