feat: support ESLint 8.x #465
Conversation
MichaelDeBoey
added
the
BREAKING CHANGE
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
acb32a1
to
26e24bd
Compare
MichaelDeBoey
force-pushed
the
update-dependencies-v5
branch
from
e098920
to
f7932d8
Compare
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
26e24bd
to
3ccb5fe
Compare
MichaelDeBoey
force-pushed
the
eslint-8
branch
2 times, most recently
from
be2ec67
to
c8d3a53
Compare
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
c8d3a53
to
eae87b7
Compare
.eslintrc.json
Outdated
| /** Temporary disable eslint-config-kentcdodds until it supports ESLint v8 | ||
| * This package is a dependency of eslint-config-kentcdodds, so because it's | ||
| * a devDependency to our package, we need to support ESLint v8 first. | ||
| */ | ||
| // 'kentcdodds', |
There was a problem hiding this comment.
Ok so rather than this, since other plugins are failing with ESLint v8 too, it would be better to stick to ESLint v7 in our dev dependencies so we don't block the release of our v5 for some dev dependencies.
Let's downgrade ESLint to v7 in our dev dependencies then, re-enable kentcdodds plugin, and move the list of pending plugins to be compatible with ESLint v8 to a separate issue so when all are ready we can upgrade to v8 in our dev dependencies.
| @@ -52,7 +52,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| node: [12.22.0, 12, 14.17.0, 14, '16.0', 16] | |||
| eslint: [7.5, 7] | |||
| eslint: [7.5, 7, 8] | |||
There was a problem hiding this comment.
By running this we make sure our plugin works for both ESLint v7 and v8 even if we use v7 in dev dependencies.
package.json
Outdated
| "cpy-cli": "^3.1.1", | ||
| "eslint": "^7.32.0", | ||
| "eslint-config-kentcdodds": "^19.1.1", | ||
| "eslint": "^8.0.0", |
There was a problem hiding this comment.
As mentioned in previous comment, let's put this back to v7 so we can go ahead with the release of our plugin v5:
| "eslint": "^8.0.0", | |
| "eslint": "^7.32.0", |
There was a problem hiding this comment.
I did the requested changes myself @MichaelDeBoey!
I'm moving to a different PR the upgrade of ESLint v8 in the dev dependencies, with all the list of pending plugins to get updated.
|
🎉 This PR is included in version 5.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ESLint v8.0.0 is released 🎉
Dependencies should be compatible with ESLint 8 too before we can merge this one:
@typescript-eslint/experimental-utils(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.categoryfrom rules typescript-eslint/typescript-eslint#3800PrivateIdentifiertypescript-eslint/typescript-eslint#3808v5.0.0devDependency compatibility with ESLint 8:
@typescript-eslint/eslint-plugin(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.categoryfrom rules typescript-eslint/typescript-eslint#3800PrivateIdentifiertypescript-eslint/typescript-eslint#3808v5.0.0@typescript-eslint/parser(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.categoryfrom rules typescript-eslint/typescript-eslint#3800PrivateIdentifiertypescript-eslint/typescript-eslint#3808v5.0.0eslint-config-kentcdodds(Support ESLint 8.x kentcdodds/eslint-config-kentcdodds#117)eslint-config-prettier(Support ESLint 8.x prettier/eslint-config-prettier#200)Releaseeslint-plugin-import(Support ESLint 8.x import-js/eslint-plugin-import#2211)v2.25.0eslint-plugin-jest(Support ESLint 8.x jest-community/eslint-plugin-jest#881)hasSuggestionfor ESLint v8 jest-community/eslint-plugin-jest#898hasSuggestionsrather thanhasSuggestionjest-community/eslint-plugin-jest#899eslint@8jest-community/eslint-plugin-jest#940@typescript-eslint/experimental-utilsto v5 jest-community/eslint-plugin-jest#941@typescript-eslint/eslint-plugin@5jest-community/eslint-plugin-jest#942v24.4.1v24.4.2v25.0.0v25.0.4v25.0.5v25.1.0eslint-plugin-jest-formatting(Support ESLint 8.x dangreenisrael/eslint-plugin-jest-formatting#107)v3.1.0eslint-plugin-node(Support ESLint 8.x mysticatea/eslint-plugin-node#294)eslint-plugin-prettier(Support ESLint 8.x prettier/eslint-plugin-prettier#427)Releaseeslint-plugin-promise(Support ESLint 8.x eslint-community/eslint-plugin-promise#218)v6.0.0Closes #462