Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: UI improvements to searchbar #989

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conversation

alkshendra
Copy link
Contributor

Motivation

Wanted to make this already awesome project a lil better! 🍺

Have you read the Contributing Guidelines on pull requests?

Yes!

Test Plan

  1. Open the application in chrome/firefox and reduce the browser width
  2. Type anything in the search bar
  3. Resize to smaller sizes and test

GIFs:
Tablet sizes

Before:
2018-09-28 01 32 20

After:
2018-09-28 02 38 57

Mobile sizes

Before:
2018-09-28 02 39 43

After:
2018-09-28 02 40 39

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 15625eb

https://deploy-preview-989--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 27, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endiliey endiliey changed the title UI improvements to searchbar style: UI improvements to searchbar Sep 28, 2018
@endiliey endiliey merged commit d2dd047 into facebook:master Sep 28, 2018
@endiliey
Copy link
Contributor

endiliey commented Sep 28, 2018

Thanks a lot @alkshendra

shipped

@Haroenv
Copy link

Haroenv commented Sep 28, 2018

I like it! there's a little too much padding at the bottom of the logo IMO, but could be fixed in another PR

@endiliey
Copy link
Contributor

Kinda true. It seems like a "good first issue". Do you mind helping to file an issue for that ? A PR is fine too, but we'd love getting more contributors 😈

@alkshendra
Copy link
Contributor Author

@Haroenv @endiliey Actually, that extra padding issue has been fixed in this PR, I had recorded the GIFs before fixing that! 😅

Here's the fix LOC from my PR:

.navigationSlider .slidingNav .navSearchWrapper .algolia-docsearch-footer a {
  height: auto;
}

@endiliey
Copy link
Contributor

endiliey commented Sep 28, 2018

😂🤣. I only looked through the recorded gif when haro pointed that out.

The gif can be very convincing... 😐

Edit: and misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants