Skip to content

Commit

Permalink
Back out "Quote --sourcemap-output argument during ios build"
Browse files Browse the repository at this point in the history
Summary:
Changelog: [Internal] Revert --sourcemap-output argument

Reverting on main from discussion from the 67 release:
reactwg/react-native-releases#1 (comment)

Original commit changeset: 0c2d98746b36

Reviewed By: GijsWeterings

Differential Revision: D32734743

fbshipit-source-id: cc3130581d01bdcdc9f5d483161ae9506fdbf7b8
  • Loading branch information
Luna Wei authored and facebook-github-bot committed Dec 1, 2021
1 parent 1989ad3 commit cdce733
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions scripts/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ fi

BUNDLE_FILE="$CONFIGURATION_BUILD_DIR/main.jsbundle"

EXTRA_ARGS=()
EXTRA_ARGS=

case "$PLATFORM_NAME" in
"macosx")
Expand All @@ -144,12 +144,12 @@ if [[ $EMIT_SOURCEMAP == true ]]; then
else
PACKAGER_SOURCEMAP_FILE="$SOURCEMAP_FILE"
fi
EXTRA_ARGS+=("--sourcemap-output" "$PACKAGER_SOURCEMAP_FILE")
EXTRA_ARGS="$EXTRA_ARGS --sourcemap-output $PACKAGER_SOURCEMAP_FILE"
fi

# Hermes doesn't require JS minification.
if [[ $USE_HERMES == true && $DEV == false ]]; then
EXTRA_ARGS+=("--minify" "false")
EXTRA_ARGS="$EXTRA_ARGS --minify false"
fi

"$NODE_BINARY" $NODE_ARGS "$CLI_PATH" $BUNDLE_COMMAND \
Expand All @@ -160,8 +160,8 @@ fi
--reset-cache \
--bundle-output "$BUNDLE_FILE" \
--assets-dest "$DEST" \
"${EXTRA_ARGS[@]}" \
"${EXTRA_PACKAGER_ARGS[@]}"
$EXTRA_ARGS \
$EXTRA_PACKAGER_ARGS

if [[ $USE_HERMES != true ]]; then
cp "$BUNDLE_FILE" "$DEST/"
Expand Down

0 comments on commit cdce733

Please sign in to comment.