fix[devtools]: allow element updates polling only if bridge is alive #27067

hoxyq · 2023-07-07T16:11:41Z

When some element is inspected in DevTools, we have a polling which updates the data for this element.
Sometimes when service worker dies or bridge is getting shutdown, we continue to poll this data and will spam with the same "timed out error".

These changes add an explicit check that polling is allowed only while bridge is alive.

List of changes: * refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime ([hoxyq](https://github.com/hoxyq) in [#27215](#27215)) * refactor[devtools/extension]: minify production builds to strip comments ([hoxyq](https://github.com/hoxyq) in [#27304](#27304)) * fix[devtools]: allow element updates polling only if bridge is alive ([hoxyq](https://github.com/hoxyq) in [#27067](#27067)) * refactor: resolve browser via env variables based on build rather than user agent ([hoxyq](https://github.com/hoxyq) in [#27179](#27179)) * fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case ([hoxyq](https://github.com/hoxyq) in [#27147](#27147)) * Feat:-Added open in editor to appear by default ([Biki-das](https://github.com/Biki-das) in [#26949](#26949)) * fix[devtools/inspect]: null check memoized props before trying to call hasOwnProperty ([hoxyq](https://github.com/hoxyq) in [#27057](#27057)) * rename SuspenseList export to unstable_SuspenseList ([noahlemen](https://github.com/noahlemen) in [#27061](#27061))

…acebook#27067) When some element is inspected in DevTools, we have a polling which updates the data for this element. Sometimes when service worker dies or bridge is getting shutdown, we continue to poll this data and will spam with the same "timed out error". <img width="1728" alt="Screenshot 2023-07-28 at 17 39 23" src="https://github.com/facebook/react/assets/28902667/220c4504-1ccc-4e87-9d78-bfff8b708230"> These changes add an explicit check that polling is allowed only while bridge is alive.

List of changes: * refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime ([hoxyq](https://github.com/hoxyq) in [facebook#27215](facebook#27215)) * refactor[devtools/extension]: minify production builds to strip comments ([hoxyq](https://github.com/hoxyq) in [facebook#27304](facebook#27304)) * fix[devtools]: allow element updates polling only if bridge is alive ([hoxyq](https://github.com/hoxyq) in [facebook#27067](facebook#27067)) * refactor: resolve browser via env variables based on build rather than user agent ([hoxyq](https://github.com/hoxyq) in [facebook#27179](facebook#27179)) * fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case ([hoxyq](https://github.com/hoxyq) in [facebook#27147](facebook#27147)) * Feat:-Added open in editor to appear by default ([Biki-das](https://github.com/Biki-das) in [facebook#26949](facebook#26949)) * fix[devtools/inspect]: null check memoized props before trying to call hasOwnProperty ([hoxyq](https://github.com/hoxyq) in [facebook#27057](facebook#27057)) * rename SuspenseList export to unstable_SuspenseList ([noahlemen](https://github.com/noahlemen) in [facebook#27061](facebook#27061))

…27067) When some element is inspected in DevTools, we have a polling which updates the data for this element. Sometimes when service worker dies or bridge is getting shutdown, we continue to poll this data and will spam with the same "timed out error". <img width="1728" alt="Screenshot 2023-07-28 at 17 39 23" src="https://github.com/facebook/react/assets/28902667/220c4504-1ccc-4e87-9d78-bfff8b708230"> These changes add an explicit check that polling is allowed only while bridge is alive. DiffTrain build for commit 41e9c17.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 7, 2023

fix[devtools]: allow element updates polling only if bridge is alive

4c22ddf

hoxyq force-pushed the devtools/fix-polling-element-updates branch from 38bea8c to 4c22ddf Compare July 7, 2023 16:13

hoxyq requested review from tyao1 and kassens July 28, 2023 16:29

hoxyq marked this pull request as ready for review July 28, 2023 16:32

hoxyq merged commit 41e9c17 into facebook:main Aug 29, 2023
2 checks passed

hoxyq deleted the devtools/fix-polling-element-updates branch August 29, 2023 09:40

hoxyq mentioned this pull request Aug 29, 2023

React DevTools 4.28.0 -> 4.28.1 #27305

Merged

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix[devtools]: allow element updates polling only if bridge is alive #27067

fix[devtools]: allow element updates polling only if bridge is alive #27067

hoxyq commented Jul 7, 2023 •

edited

Loading

fix[devtools]: allow element updates polling only if bridge is alive #27067

fix[devtools]: allow element updates polling only if bridge is alive #27067

Conversation

hoxyq commented Jul 7, 2023 • edited Loading

hoxyq commented Jul 7, 2023 •

edited

Loading