Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Float] Refactor public interface and internal HostDispatcher implementation #27361

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Sep 12, 2023

When Float was first developed the internal implementation and external interface were the same. This is problematic for a few reasons. One, the public interface is typed but it is also untrusted and we should not assume that it is actually respected. Two, the internal implementations can get called from places other than the the public interface and having to construct an options argument that ends up being destructured to process the request is computationally wasteful and may limit JIT optimizations to some degree. Lastly, the wire format was not as compressed as it could be and it was untyped.

This refactor aims to address that by separating the public interface from the internal implementations so we can solve these challenges and also make it easier to change Float in the future

  • The internal dispatcher method preinit is now preinitStyle and preinitScript.
  • The internal dispatcher method preinitModule is now preinitModuleScript in anticipation of different implementations for other module types in the future.
  • The wire format is explicitly typed and only includes options if they are actually used omitting undefined and nulls.
  • Some function arguments are not options even if they are optional. For instance precedence can be null/undefined because we deafult it to 'default' however we don't cosnider this an option because it is not something we transparently apply as props to the underlying instance.
  • Fixes a problem with keying images in flight where srcset and sizes were not being taken into account.
  • Moves argument validation into the ReactDOMFloat file where it is shared with all runtimes that expose these methods
  • Fixes crossOrigin serialization to use empty string except when 'use-credentials'

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 12, 2023
@react-sizebot
Copy link

react-sizebot commented Sep 12, 2023

Comparing: 41f0e9d...8a780a4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.46% 165.63 kB 166.38 kB +0.39% 51.88 kB 52.08 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.43% 174.82 kB 175.58 kB +0.33% 54.69 kB 54.87 kB
facebook-www/ReactDOM-prod.classic.js +0.20% 570.44 kB 571.59 kB +0.17% 100.45 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js +0.21% 554.21 kB 555.37 kB +0.13% 97.61 kB 97.74 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +205.81% 5.08 kB 15.52 kB +141.00% 1.44 kB 3.48 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +204.76% 5.10 kB 15.55 kB +138.27% 1.47 kB 3.51 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +193.67% 5.56 kB 16.33 kB +130.33% 1.56 kB 3.60 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +192.77% 5.59 kB 16.36 kB +128.26% 1.59 kB 3.63 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +118.24% 7.74 kB 16.88 kB +58.23% 2.54 kB 4.02 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +112.77% 8.33 kB 17.73 kB +55.23% 2.67 kB 4.14 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +106.22% 1.50 kB 3.09 kB +54.43% 0.73 kB 1.13 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +104.40% 1.52 kB 3.11 kB +52.51% 0.76 kB 1.16 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +95.50% 1.67 kB 3.26 kB +48.89% 0.81 kB 1.21 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +93.91% 1.69 kB 3.28 kB +44.59% 0.86 kB 1.24 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +92.49% 1.72 kB 3.31 kB +43.54% 0.88 kB 1.27 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +84.79% 1.87 kB 3.46 kB +41.52% 0.93 kB 1.32 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +3.22% 9.68 kB 9.99 kB +2.05% 3.76 kB 3.83 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +3.22% 9.68 kB 9.99 kB +2.05% 3.76 kB 3.83 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +3.15% 38.09 kB 39.28 kB +2.00% 9.30 kB 9.49 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +3.15% 38.09 kB 39.28 kB +2.00% 9.30 kB 9.49 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +3.00% 10.38 kB 10.70 kB +1.81% 4.04 kB 4.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +3.00% 10.38 kB 10.70 kB +1.81% 4.04 kB 4.12 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.93% 10.65 kB 10.96 kB +1.75% 4.11 kB 4.18 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.93% 10.65 kB 10.96 kB +1.75% 4.11 kB 4.18 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.93% 10.65 kB 10.96 kB +1.86% 4.14 kB 4.22 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.93% 10.65 kB 10.96 kB +1.86% 4.14 kB 4.22 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.82% 11.05 kB 11.36 kB +1.73% 4.28 kB 4.35 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.82% 11.05 kB 11.36 kB +1.73% 4.28 kB 4.35 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +2.78% 43.17 kB 44.37 kB +1.77% 10.31 kB 10.49 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +2.77% 11.00 kB 11.30 kB +1.38% 4.13 kB 4.18 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.74% 11.37 kB 11.68 kB +1.68% 4.41 kB 4.49 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.74% 11.37 kB 11.68 kB +1.68% 4.41 kB 4.49 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.67% 11.63 kB 11.95 kB +1.60% 4.50 kB 4.58 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.67% 11.63 kB 11.95 kB +1.60% 4.50 kB 4.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +2.61% 11.70 kB 12.00 kB +1.22% 4.41 kB 4.47 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.61% 94.77 kB 97.24 kB +2.77% 22.55 kB 23.18 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.61% 94.77 kB 97.24 kB +2.77% 22.55 kB 23.18 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.54% 11.96 kB 12.27 kB +1.26% 4.52 kB 4.57 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.54% 11.98 kB 12.28 kB +1.49% 4.49 kB 4.56 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.53% 50.18 kB 51.45 kB +2.72% 12.06 kB 12.39 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.53% 50.18 kB 51.45 kB +2.72% 12.06 kB 12.39 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.52% 50.34 kB 51.61 kB +2.69% 12.12 kB 12.45 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.52% 50.34 kB 51.61 kB +2.69% 12.12 kB 12.45 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.51% 98.49 kB 100.96 kB +2.64% 23.75 kB 24.38 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.51% 98.49 kB 100.96 kB +2.64% 23.75 kB 24.38 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.50% 104.15 kB 106.76 kB +2.58% 24.13 kB 24.75 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.50% 104.15 kB 106.76 kB +2.58% 24.13 kB 24.75 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.50% 98.90 kB 101.37 kB +2.63% 23.86 kB 24.49 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.50% 98.90 kB 101.37 kB +2.63% 23.86 kB 24.49 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.49% 99.18 kB 101.65 kB +2.67% 23.32 kB 23.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.46% 12.38 kB 12.68 kB +1.40% 4.65 kB 4.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.42% 102.20 kB 104.67 kB +2.62% 24.33 kB 24.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.42% 102.20 kB 104.67 kB +2.62% 24.33 kB 24.97 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.41% 56.22 kB 57.58 kB +2.71% 13.03 kB 13.38 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.41% 56.22 kB 57.58 kB +2.71% 13.03 kB 13.38 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.41% 52.83 kB 54.11 kB +2.68% 12.83 kB 13.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.41% 52.83 kB 54.11 kB +2.68% 12.83 kB 13.17 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.40% 53.04 kB 54.31 kB +2.59% 12.88 kB 13.22 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.40% 53.04 kB 54.31 kB +2.59% 12.88 kB 13.22 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.39% 12.70 kB 13.01 kB +1.40% 4.79 kB 4.86 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.39% 103.35 kB 105.82 kB +2.56% 24.64 kB 25.27 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.39% 109.25 kB 111.86 kB +2.49% 25.01 kB 25.63 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.38% 103.76 kB 106.23 kB +2.54% 24.77 kB 25.40 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.37% 104.24 kB 106.71 kB +2.55% 24.95 kB 25.58 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.37% 104.24 kB 106.71 kB +2.55% 24.95 kB 25.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.35% 12.95 kB 13.25 kB +1.27% 4.88 kB 4.94 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.34% 54.33 kB 55.60 kB +2.57% 13.21 kB 13.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.34% 54.33 kB 55.60 kB +2.57% 13.21 kB 13.55 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.32% 106.61 kB 109.08 kB +2.49% 25.10 kB 25.73 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.30% 55.23 kB 56.50 kB +2.51% 13.06 kB 13.39 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.29% 55.39 kB 56.66 kB +2.48% 13.12 kB 13.44 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.29% 55.57 kB 56.84 kB +2.50% 13.60 kB 13.94 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.29% 55.57 kB 56.84 kB +2.50% 13.60 kB 13.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.27% 108.66 kB 111.13 kB +2.44% 25.69 kB 26.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.26% 56.29 kB 57.56 kB +2.48% 13.75 kB 14.09 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.26% 56.29 kB 57.56 kB +2.48% 13.75 kB 14.09 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.20% 61.57 kB 62.93 kB +2.43% 14.06 kB 14.40 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.20% 57.88 kB 59.15 kB +2.45% 13.82 kB 14.16 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.19% 58.09 kB 59.36 kB +2.39% 13.91 kB 14.24 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.16% 24.17 kB 24.69 kB +2.54% 8.39 kB 8.60 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.16% 24.17 kB 24.69 kB +2.54% 8.39 kB 8.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.14% 59.37 kB 60.65 kB +2.38% 14.23 kB 14.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.10% 60.61 kB 61.89 kB +2.33% 14.62 kB 14.96 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.07% 61.34 kB 62.61 kB +2.30% 14.77 kB 15.11 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.06% 25.33 kB 25.85 kB +2.55% 8.66 kB 8.88 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.06% 25.54 kB 26.07 kB +2.50% 8.68 kB 8.89 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.06% 25.54 kB 26.07 kB +2.50% 8.68 kB 8.89 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.03% 25.72 kB 26.24 kB +2.32% 8.81 kB 9.01 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.03% 25.72 kB 26.24 kB +2.32% 8.81 kB 9.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +2.02% 25.87 kB 26.39 kB +2.49% 8.79 kB 9.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +2.02% 25.87 kB 26.39 kB +2.49% 8.79 kB 9.01 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js = 391.95 kB 383.00 kB = 84.09 kB 82.63 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 375.43 kB 366.74 kB = 83.51 kB 82.06 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js = 385.61 kB 376.66 kB = 83.37 kB 81.90 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 374.54 kB 365.85 kB = 83.31 kB 81.86 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 374.13 kB 365.44 kB = 83.19 kB 81.74 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 369.99 kB 361.30 kB = 82.96 kB 81.47 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 368.08 kB 359.39 kB = 82.50 kB 81.02 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 365.53 kB 356.84 kB = 82.02 kB 80.57 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js = 368.31 kB 359.36 kB = 80.21 kB 78.75 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js = 368.28 kB 359.34 kB = 80.19 kB 78.72 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js = 368.09 kB 359.14 kB = 79.74 kB 78.27 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js = 368.06 kB 359.12 kB = 79.71 kB 78.25 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 353.15 kB 344.46 kB = 79.33 kB 77.85 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 353.13 kB 344.44 kB = 79.31 kB 77.83 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 352.94 kB 344.25 kB = 79.35 kB 77.90 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 352.91 kB 344.22 kB = 79.33 kB 77.87 kB
facebook-www/ReactDOMServer-dev.classic.js = 368.31 kB 359.21 kB = 81.64 kB 80.12 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 351.87 kB 343.18 kB = 79.44 kB 77.98 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 351.85 kB 343.16 kB = 79.42 kB 77.96 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 351.46 kB 342.77 kB = 79.32 kB 77.86 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 351.44 kB 342.75 kB = 79.29 kB 77.84 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 351.24 kB 342.55 kB = 78.87 kB 77.40 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 351.22 kB 342.53 kB = 78.85 kB 77.37 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 348.69 kB 340.00 kB = 78.39 kB 76.96 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 348.66 kB 339.97 kB = 78.36 kB 76.94 kB
facebook-www/ReactDOMServer-dev.modern.js = 360.88 kB 351.79 kB = 79.99 kB 78.47 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 356.08 kB 346.98 kB = 78.83 kB 77.32 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +205.81% 5.08 kB 15.52 kB +141.00% 1.44 kB 3.48 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +204.76% 5.10 kB 15.55 kB +138.27% 1.47 kB 3.51 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +193.67% 5.56 kB 16.33 kB +130.33% 1.56 kB 3.60 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +192.77% 5.59 kB 16.36 kB +128.26% 1.59 kB 3.63 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +118.24% 7.74 kB 16.88 kB +58.23% 2.54 kB 4.02 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +112.77% 8.33 kB 17.73 kB +55.23% 2.67 kB 4.14 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +106.22% 1.50 kB 3.09 kB +54.43% 0.73 kB 1.13 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +104.40% 1.52 kB 3.11 kB +52.51% 0.76 kB 1.16 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +95.50% 1.67 kB 3.26 kB +48.89% 0.81 kB 1.21 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +93.91% 1.69 kB 3.28 kB +44.59% 0.86 kB 1.24 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +92.49% 1.72 kB 3.31 kB +43.54% 0.88 kB 1.27 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +84.79% 1.87 kB 3.46 kB +41.52% 0.93 kB 1.32 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +3.22% 9.68 kB 9.99 kB +2.05% 3.76 kB 3.83 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +3.22% 9.68 kB 9.99 kB +2.05% 3.76 kB 3.83 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +3.15% 38.09 kB 39.28 kB +2.00% 9.30 kB 9.49 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +3.15% 38.09 kB 39.28 kB +2.00% 9.30 kB 9.49 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +3.00% 10.38 kB 10.70 kB +1.81% 4.04 kB 4.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +3.00% 10.38 kB 10.70 kB +1.81% 4.04 kB 4.12 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.93% 10.65 kB 10.96 kB +1.75% 4.11 kB 4.18 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.93% 10.65 kB 10.96 kB +1.75% 4.11 kB 4.18 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.93% 10.65 kB 10.96 kB +1.86% 4.14 kB 4.22 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.93% 10.65 kB 10.96 kB +1.86% 4.14 kB 4.22 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.82% 11.05 kB 11.36 kB +1.73% 4.28 kB 4.35 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.82% 11.05 kB 11.36 kB +1.73% 4.28 kB 4.35 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.min.js +2.78% 43.17 kB 44.37 kB +1.77% 10.31 kB 10.49 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js +2.77% 11.00 kB 11.30 kB +1.38% 4.13 kB 4.18 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.74% 11.37 kB 11.68 kB +1.68% 4.41 kB 4.49 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.74% 11.37 kB 11.68 kB +1.68% 4.41 kB 4.49 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.67% 11.63 kB 11.95 kB +1.60% 4.50 kB 4.58 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.67% 11.63 kB 11.95 kB +1.60% 4.50 kB 4.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js +2.61% 11.70 kB 12.00 kB +1.22% 4.41 kB 4.47 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.61% 94.77 kB 97.24 kB +2.77% 22.55 kB 23.18 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.61% 94.77 kB 97.24 kB +2.77% 22.55 kB 23.18 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js +2.54% 11.96 kB 12.27 kB +1.26% 4.52 kB 4.57 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js +2.54% 11.98 kB 12.28 kB +1.49% 4.49 kB 4.56 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.53% 50.18 kB 51.45 kB +2.72% 12.06 kB 12.39 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.53% 50.18 kB 51.45 kB +2.72% 12.06 kB 12.39 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.52% 50.34 kB 51.61 kB +2.69% 12.12 kB 12.45 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.52% 50.34 kB 51.61 kB +2.69% 12.12 kB 12.45 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.51% 98.49 kB 100.96 kB +2.64% 23.75 kB 24.38 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.51% 98.49 kB 100.96 kB +2.64% 23.75 kB 24.38 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.50% 104.15 kB 106.76 kB +2.58% 24.13 kB 24.75 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.50% 104.15 kB 106.76 kB +2.58% 24.13 kB 24.75 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.50% 98.90 kB 101.37 kB +2.63% 23.86 kB 24.49 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.50% 98.90 kB 101.37 kB +2.63% 23.86 kB 24.49 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +2.49% 99.18 kB 101.65 kB +2.67% 23.32 kB 23.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js +2.46% 12.38 kB 12.68 kB +1.40% 4.65 kB 4.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.42% 102.20 kB 104.67 kB +2.62% 24.33 kB 24.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.42% 102.20 kB 104.67 kB +2.62% 24.33 kB 24.97 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.41% 56.22 kB 57.58 kB +2.71% 13.03 kB 13.38 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.41% 56.22 kB 57.58 kB +2.71% 13.03 kB 13.38 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.41% 52.83 kB 54.11 kB +2.68% 12.83 kB 13.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.41% 52.83 kB 54.11 kB +2.68% 12.83 kB 13.17 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.40% 53.04 kB 54.31 kB +2.59% 12.88 kB 13.22 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.40% 53.04 kB 54.31 kB +2.59% 12.88 kB 13.22 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js +2.39% 12.70 kB 13.01 kB +1.40% 4.79 kB 4.86 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +2.39% 103.35 kB 105.82 kB +2.56% 24.64 kB 25.27 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.39% 109.25 kB 111.86 kB +2.49% 25.01 kB 25.63 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +2.38% 103.76 kB 106.23 kB +2.54% 24.77 kB 25.40 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.37% 104.24 kB 106.71 kB +2.55% 24.95 kB 25.58 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.37% 104.24 kB 106.71 kB +2.55% 24.95 kB 25.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +2.35% 12.95 kB 13.25 kB +1.27% 4.88 kB 4.94 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.34% 54.33 kB 55.60 kB +2.57% 13.21 kB 13.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.34% 54.33 kB 55.60 kB +2.57% 13.21 kB 13.55 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +2.32% 106.61 kB 109.08 kB +2.49% 25.10 kB 25.73 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +2.30% 55.23 kB 56.50 kB +2.51% 13.06 kB 13.39 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +2.29% 55.39 kB 56.66 kB +2.48% 13.12 kB 13.44 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.29% 55.57 kB 56.84 kB +2.50% 13.60 kB 13.94 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.29% 55.57 kB 56.84 kB +2.50% 13.60 kB 13.94 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.27% 108.66 kB 111.13 kB +2.44% 25.69 kB 26.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.26% 56.29 kB 57.56 kB +2.48% 13.75 kB 14.09 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.26% 56.29 kB 57.56 kB +2.48% 13.75 kB 14.09 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.development.js +2.20% 61.57 kB 62.93 kB +2.43% 14.06 kB 14.40 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +2.20% 57.88 kB 59.15 kB +2.45% 13.82 kB 14.16 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +2.19% 58.09 kB 59.36 kB +2.39% 13.91 kB 14.24 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.16% 24.17 kB 24.69 kB +2.54% 8.39 kB 8.60 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.16% 24.17 kB 24.69 kB +2.54% 8.39 kB 8.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.14% 59.37 kB 60.65 kB +2.38% 14.23 kB 14.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.10% 60.61 kB 61.89 kB +2.33% 14.62 kB 14.96 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +2.07% 61.34 kB 62.61 kB +2.30% 14.77 kB 15.11 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +2.06% 25.33 kB 25.85 kB +2.55% 8.66 kB 8.88 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.06% 25.54 kB 26.07 kB +2.50% 8.68 kB 8.89 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.06% 25.54 kB 26.07 kB +2.50% 8.68 kB 8.89 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.03% 25.72 kB 26.24 kB +2.32% 8.81 kB 9.01 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.03% 25.72 kB 26.24 kB +2.32% 8.81 kB 9.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +2.02% 25.87 kB 26.39 kB +2.49% 8.79 kB 9.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +2.02% 25.87 kB 26.39 kB +2.49% 8.79 kB 9.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +1.97% 26.76 kB 27.28 kB +2.37% 8.99 kB 9.20 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +1.95% 26.81 kB 27.33 kB +2.25% 9.13 kB 9.33 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +1.95% 26.81 kB 27.33 kB +2.25% 9.13 kB 9.33 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +1.94% 26.93 kB 27.46 kB +2.28% 9.11 kB 9.32 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +1.93% 27.08 kB 27.60 kB +2.40% 9.09 kB 9.30 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.91% 27.33 kB 27.86 kB +2.24% 9.28 kB 9.49 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.91% 27.33 kB 27.86 kB +2.24% 9.28 kB 9.49 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +1.87% 27.96 kB 28.49 kB +2.34% 9.41 kB 9.63 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.84% 28.49 kB 29.02 kB +2.31% 9.57 kB 9.79 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js +0.46% 165.55 kB 166.31 kB +0.38% 51.85 kB 52.05 kB
oss-stable/react-dom/cjs/react-dom.production.min.js +0.46% 165.63 kB 166.38 kB +0.39% 51.88 kB 52.08 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js +0.45% 165.43 kB 166.18 kB +0.35% 52.28 kB 52.46 kB
oss-stable/react-dom/umd/react-dom.production.min.js +0.45% 165.51 kB 166.26 kB +0.36% 52.30 kB 52.49 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.43% 174.82 kB 175.58 kB +0.33% 54.69 kB 54.87 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js +0.43% 175.18 kB 175.94 kB +0.32% 54.31 kB 54.49 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +0.43% 175.26 kB 176.02 kB +0.32% 54.34 kB 54.52 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js +0.43% 174.42 kB 175.17 kB +0.31% 54.63 kB 54.80 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +0.43% 174.50 kB 175.25 kB +0.31% 54.65 kB 54.83 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.43% 174.61 kB 175.36 kB +0.30% 54.96 kB 55.12 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.42% 181.03 kB 181.79 kB +0.29% 57.03 kB 57.20 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.41% 184.47 kB 185.23 kB +0.31% 57.08 kB 57.25 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.41% 183.61 kB 184.36 kB +0.30% 57.32 kB 57.49 kB
facebook-www/ReactDOM-prod.modern.js +0.21% 554.21 kB 555.37 kB +0.13% 97.61 kB 97.74 kB
facebook-www/ReactDOM-prod.classic.js +0.20% 570.44 kB 571.59 kB +0.17% 100.45 kB 100.62 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.20% 570.75 kB 571.91 kB +0.14% 101.72 kB 101.86 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 158.40 kB 156.79 kB = 29.36 kB 29.14 kB
facebook-www/ReactDOMServer-prod.classic.js = 157.15 kB 155.54 kB = 28.64 kB 28.43 kB
facebook-www/ReactDOMServer-prod.modern.js = 156.25 kB 154.64 kB = 28.39 kB 28.17 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js = 73.92 kB 73.13 kB = 22.80 kB 22.70 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js = 73.64 kB 72.85 kB = 22.62 kB 22.52 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 71.45 kB 70.66 kB = 21.69 kB 21.60 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js = 69.87 kB 69.08 kB = 21.42 kB 21.33 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js = 69.19 kB 68.40 kB = 21.11 kB 21.04 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js = 69.32 kB 68.53 kB = 21.39 kB 21.27 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.min.js = 68.22 kB 67.43 kB = 21.27 kB 21.19 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.min.js = 68.20 kB 67.41 kB = 21.24 kB 21.16 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.min.js = 68.17 kB 67.38 kB = 21.27 kB 21.18 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.min.js = 68.14 kB 67.35 kB = 21.24 kB 21.15 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 67.84 kB 67.06 kB = 20.54 kB 20.43 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 67.82 kB 67.03 kB = 20.52 kB 20.41 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js = 66.47 kB 65.69 kB = 20.42 kB 20.28 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js = 66.32 kB 65.53 kB = 20.03 kB 19.93 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.min.js = 66.26 kB 65.48 kB = 20.25 kB 20.15 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.min.js = 66.24 kB 65.45 kB = 20.22 kB 20.12 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.min.js = 63.93 kB 63.15 kB = 19.83 kB 19.73 kB
oss-stable/react-dom/umd/react-dom-server.browser.production.min.js = 64.08 kB 63.29 kB = 20.12 kB 19.97 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.min.js = 63.91 kB 63.12 kB = 19.81 kB 19.71 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.production.min.js = 64.05 kB 63.27 kB = 20.10 kB 19.95 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.production.min.js = 63.12 kB 62.33 kB = 19.25 kB 19.10 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.min.js = 62.96 kB 62.18 kB = 18.93 kB 18.82 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.production.min.js = 63.10 kB 62.31 kB = 19.23 kB 19.08 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.min.js = 62.94 kB 62.15 kB = 18.90 kB 18.80 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js = 391.95 kB 383.00 kB = 84.09 kB 82.63 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 375.43 kB 366.74 kB = 83.51 kB 82.06 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js = 385.61 kB 376.66 kB = 83.37 kB 81.90 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 374.54 kB 365.85 kB = 83.31 kB 81.86 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 374.13 kB 365.44 kB = 83.19 kB 81.74 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 369.99 kB 361.30 kB = 82.96 kB 81.47 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 368.08 kB 359.39 kB = 82.50 kB 81.02 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 365.53 kB 356.84 kB = 82.02 kB 80.57 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js = 368.31 kB 359.36 kB = 80.21 kB 78.75 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js = 368.28 kB 359.34 kB = 80.19 kB 78.72 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js = 368.09 kB 359.14 kB = 79.74 kB 78.27 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js = 368.06 kB 359.12 kB = 79.71 kB 78.25 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 353.15 kB 344.46 kB = 79.33 kB 77.85 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 353.13 kB 344.44 kB = 79.31 kB 77.83 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 352.94 kB 344.25 kB = 79.35 kB 77.90 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 352.91 kB 344.22 kB = 79.33 kB 77.87 kB
facebook-www/ReactDOMServer-dev.classic.js = 368.31 kB 359.21 kB = 81.64 kB 80.12 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 351.87 kB 343.18 kB = 79.44 kB 77.98 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 351.85 kB 343.16 kB = 79.42 kB 77.96 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 351.46 kB 342.77 kB = 79.32 kB 77.86 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 351.44 kB 342.75 kB = 79.29 kB 77.84 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 351.24 kB 342.55 kB = 78.87 kB 77.40 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 351.22 kB 342.53 kB = 78.85 kB 77.37 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 348.69 kB 340.00 kB = 78.39 kB 76.96 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 348.66 kB 339.97 kB = 78.36 kB 76.94 kB
facebook-www/ReactDOMServer-dev.modern.js = 360.88 kB 351.79 kB = 79.99 kB 78.47 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 356.08 kB 346.98 kB = 78.83 kB 77.32 kB

Generated by 🚫 dangerJS against 8a780a4

@gnoff gnoff force-pushed the refactor-float-dispatcher branch 2 times, most recently from 91d987c to 6d7fbf4 Compare September 12, 2023 04:49
…al interface were the same. This is problematic for a few reasons. One, the public interface is typed but it is also untrusted and we should not assume that it is actually respected. Two, the internal implementations can get called from places other than the the public interface and having to construct an options argument that ends up being destructured to process the request is computationally wasteful and may limit JIT optimizations to some degree. Lastly, the wire format was not as compressed as it could be and it was untyped.

This refactor aims to address that by separating the public interface from the internal implementations so we can solve these challenges and also make it easier to change Float in the future

The internal dispatcher method preinit is now preinitStyle and preinitScript.
The internal dispatcher method preinitModule is now preinitModuleScript in anticipation of different implementations for other module types in the future
The wire format is explicitly typed and only includes options if they are actually used omitting undefined and nulls.
Some function arguments are not options even if they are optional. For instance precedence can be null/undefined because we deafult it to 'default' however we don't cosnider this an option because it is not something we transparently apply as props to the underlying instance.
Fixes a problem with keying images in flight wehre srcset and sizes were not being taken into account.
Moves argument validation into the ReactDOMFloat file where it is shared with all runtimes that expose these methods
@gnoff gnoff merged commit bbc8530 into facebook:main Sep 12, 2023
2 checks passed
@gnoff gnoff deleted the refactor-float-dispatcher branch September 12, 2023 15:09
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
…ntation (#27361)

When Float was first developed the internal implementation and external
interface were the same. This is problematic for a few reasons. One, the
public interface is typed but it is also untrusted and we should not
assume that it is actually respected. Two, the internal implementations
can get called from places other than the the public interface and
having to construct an options argument that ends up being destructured
to process the request is computationally wasteful and may limit JIT
optimizations to some degree. Lastly, the wire format was not as
compressed as it could be and it was untyped.

This refactor aims to address that by separating the public interface
from the internal implementations so we can solve these challenges and
also make it easier to change Float in the future

* The internal dispatcher method preinit is now preinitStyle and
preinitScript.
* The internal dispatcher method preinitModule is now
preinitModuleScript in anticipation of different implementations for
other module types in the future.
* The wire format is explicitly typed and only includes options if they
are actually used omitting undefined and nulls.
* Some function arguments are not options even if they are optional. For
instance precedence can be null/undefined because we deafult it to
'default' however we don't cosnider this an option because it is not
something we transparently apply as props to the underlying instance.
* Fixes a problem with keying images in flight where srcset and sizes
were not being taken into account.
* Moves argument validation into the ReactDOMFloat file where it is
shared with all runtimes that expose these methods
* Fixes crossOrigin serialization to use empty string except when
'use-credentials'

DiffTrain build for [bbc8530](bbc8530)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…ntation (facebook#27361)

When Float was first developed the internal implementation and external
interface were the same. This is problematic for a few reasons. One, the
public interface is typed but it is also untrusted and we should not
assume that it is actually respected. Two, the internal implementations
can get called from places other than the the public interface and
having to construct an options argument that ends up being destructured
to process the request is computationally wasteful and may limit JIT
optimizations to some degree. Lastly, the wire format was not as
compressed as it could be and it was untyped.

This refactor aims to address that by separating the public interface
from the internal implementations so we can solve these challenges and
also make it easier to change Float in the future

* The internal dispatcher method preinit is now preinitStyle and
preinitScript.
* The internal dispatcher method preinitModule is now
preinitModuleScript in anticipation of different implementations for
other module types in the future.
* The wire format is explicitly typed and only includes options if they
are actually used omitting undefined and nulls.
* Some function arguments are not options even if they are optional. For
instance precedence can be null/undefined because we deafult it to
'default' however we don't cosnider this an option because it is not
something we transparently apply as props to the underlying instance.
* Fixes a problem with keying images in flight where srcset and sizes
were not being taken into account.
* Moves argument validation into the ReactDOMFloat file where it is
shared with all runtimes that expose these methods
* Fixes crossOrigin serialization to use empty string except when
'use-credentials'
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…ntation (#27361)

When Float was first developed the internal implementation and external
interface were the same. This is problematic for a few reasons. One, the
public interface is typed but it is also untrusted and we should not
assume that it is actually respected. Two, the internal implementations
can get called from places other than the the public interface and
having to construct an options argument that ends up being destructured
to process the request is computationally wasteful and may limit JIT
optimizations to some degree. Lastly, the wire format was not as
compressed as it could be and it was untyped.

This refactor aims to address that by separating the public interface
from the internal implementations so we can solve these challenges and
also make it easier to change Float in the future

* The internal dispatcher method preinit is now preinitStyle and
preinitScript.
* The internal dispatcher method preinitModule is now
preinitModuleScript in anticipation of different implementations for
other module types in the future.
* The wire format is explicitly typed and only includes options if they
are actually used omitting undefined and nulls.
* Some function arguments are not options even if they are optional. For
instance precedence can be null/undefined because we deafult it to
'default' however we don't cosnider this an option because it is not
something we transparently apply as props to the underlying instance.
* Fixes a problem with keying images in flight where srcset and sizes
were not being taken into account.
* Moves argument validation into the ReactDOMFloat file where it is
shared with all runtimes that expose these methods
* Fixes crossOrigin serialization to use empty string except when
'use-credentials'

DiffTrain build for commit bbc8530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants