[Float][Fizz][Legacy] hoisted elements no longer emit before `<html>` in legacy apis such as `renderToString()` #27269

gnoff · 2023-08-22T16:31:41Z

renderToString is a legacy server API which used a trick to avoid having the DOCTYPE included when rendering full documents by setting the root formatcontext to HTML_MODE rather than ROOT_HTML_MODE. Previously this was of little consequence but with Float the Root mode started to be used for things like determining if we could flush hoistable elements yet. In issue #27177 we see that hoisted elements can appear before the tag when using a legacy API renderToString.

This change exports a DOCTYPE from FizzConfigDOM and FizzConfigDOMLegacy respectively, using an empty chunk in the legacy case. The only runtime perf cost here is that for legacy APIs there is an extra empty chunk to write when rendering a top level tag which is trivial enough

Fixes #27177

react-sizebot · 2023-08-22T16:35:21Z

Comparing: b277259...1120c0e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	165.67 kB	165.67 kB	=	51.99 kB	51.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.16 kB	173.16 kB	=	54.21 kB	54.21 kB
facebook-www/ReactDOM-prod.classic.js	=	570.50 kB	570.50 kB	=	100.49 kB	100.49 kB
facebook-www/ReactDOM-prod.modern.js	=	554.30 kB	554.30 kB	=	97.66 kB	97.66 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1120c0e

packages/react-dom-bindings/src/server/ReactFizzConfigDOMLegacy.js

…ing the DOCTYPE included when rendering full documents by setting the root formatcontext to HTML_MODE rather than ROOT_HTML_MODE. Previously this was of little consequence but with Float the Root mode started to be used for things like determining if we could flush hoistable elements yet. In issue facebook#27177 we see that hoisted elements can appear before the <html> tag when using a legacy API `renderToString`. This change exports a DOCTYPE from FizzConfigDOM and FizzConfigDOMLegacy respectively, using an empty chunk in the legacy case. The only runtime perf cost here is that for legacy APIs there is an extra empty chunk to write when rendering a top level <html> tag which is trivial enough

… in legacy apis such as `renderToString()` (#27269) renderToString is a legacy server API which used a trick to avoid having the DOCTYPE included when rendering full documents by setting the root formatcontext to HTML_MODE rather than ROOT_HTML_MODE. Previously this was of little consequence but with Float the Root mode started to be used for things like determining if we could flush hoistable elements yet. In issue #27177 we see that hoisted elements can appear before the <html> tag when using a legacy API `renderToString`. This change exports a DOCTYPE from FizzConfigDOM and FizzConfigDOMLegacy respectively, using an empty chunk in the legacy case. The only runtime perf cost here is that for legacy APIs there is an extra empty chunk to write when rendering a top level <html> tag which is trivial enough Fixes #27177 DiffTrain build for [86198b9](86198b9)

… in legacy apis such as `renderToString()` (facebook#27269) renderToString is a legacy server API which used a trick to avoid having the DOCTYPE included when rendering full documents by setting the root formatcontext to HTML_MODE rather than ROOT_HTML_MODE. Previously this was of little consequence but with Float the Root mode started to be used for things like determining if we could flush hoistable elements yet. In issue facebook#27177 we see that hoisted elements can appear before the <html> tag when using a legacy API `renderToString`. This change exports a DOCTYPE from FizzConfigDOM and FizzConfigDOMLegacy respectively, using an empty chunk in the legacy case. The only runtime perf cost here is that for legacy APIs there is an extra empty chunk to write when rendering a top level <html> tag which is trivial enough Fixes facebook#27177

… in legacy apis such as `renderToString()` (#27269) renderToString is a legacy server API which used a trick to avoid having the DOCTYPE included when rendering full documents by setting the root formatcontext to HTML_MODE rather than ROOT_HTML_MODE. Previously this was of little consequence but with Float the Root mode started to be used for things like determining if we could flush hoistable elements yet. In issue #27177 we see that hoisted elements can appear before the <html> tag when using a legacy API `renderToString`. This change exports a DOCTYPE from FizzConfigDOM and FizzConfigDOMLegacy respectively, using an empty chunk in the legacy case. The only runtime perf cost here is that for legacy APIs there is an extra empty chunk to write when rendering a top level <html> tag which is trivial enough Fixes #27177 DiffTrain build for commit 86198b9.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 22, 2023

sebmarkbage reviewed Aug 22, 2023

View reviewed changes

packages/react-dom-bindings/src/server/ReactFizzConfigDOMLegacy.js Outdated Show resolved Hide resolved

gnoff force-pushed the bugfix-hoisting branch from b10b923 to e0a7c31 Compare August 22, 2023 16:49

gnoff requested a review from sebmarkbage August 22, 2023 16:50

sebmarkbage reviewed Aug 22, 2023

View reviewed changes

packages/react-dom-bindings/src/server/ReactFizzConfigDOMLegacy.js Outdated Show resolved Hide resolved

sebmarkbage approved these changes Aug 22, 2023

View reviewed changes

gnoff force-pushed the bugfix-hoisting branch from e0a7c31 to bc03950 Compare August 22, 2023 17:29

gnoff force-pushed the bugfix-hoisting branch from bc03950 to 1120c0e Compare August 22, 2023 17:33

gnoff merged commit 86198b9 into facebook:main Aug 22, 2023
2 checks passed

gnoff deleted the bugfix-hoisting branch August 22, 2023 17:54

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Float][Fizz][Legacy] hoisted elements no longer emit before `<html>` in legacy apis such as `renderToString()` #27269

[Float][Fizz][Legacy] hoisted elements no longer emit before `<html>` in legacy apis such as `renderToString()` #27269

gnoff commented Aug 22, 2023 •

edited

Loading

react-sizebot commented Aug 22, 2023 •

edited

Loading

[Float][Fizz][Legacy] hoisted elements no longer emit before <html> in legacy apis such as renderToString() #27269

[Float][Fizz][Legacy] hoisted elements no longer emit before <html> in legacy apis such as renderToString() #27269

Conversation

gnoff commented Aug 22, 2023 • edited Loading

react-sizebot commented Aug 22, 2023 • edited Loading

Critical size changes

Significant size changes

[Float][Fizz][Legacy] hoisted elements no longer emit before `<html>` in legacy apis such as `renderToString()` #27269

[Float][Fizz][Legacy] hoisted elements no longer emit before `<html>` in legacy apis such as `renderToString()` #27269

gnoff commented Aug 22, 2023 •

edited

Loading

react-sizebot commented Aug 22, 2023 •

edited

Loading