Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply breaking change in replay renderer API. #1408

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 7, 2023

Motivation and Context

This PR changes a call to a replay renderer function to accommodate this breaking API change: habitat-sim#2044.

How Has This Been Tested

Tests pass locally with habitat-sim#2044.

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from mosra and eundersander June 7, 2023 19:06
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 7, 2023
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc merged commit 7c9c3ad into main Jun 13, 2023
@0mdc 0mdc deleted the breaking-replay-renderer-api-change branch June 14, 2023 01:54
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Fix breaking change in replay renderer api.

* Change replay renderer render api for keyword arguments.
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* Fix breaking change in replay renderer api.

* Change replay renderer render api for keyword arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants