Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIRo: Apply breaking change in replay renderer API. #1410

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 12, 2023

Port of #1408 into the SIRo branch.

@0mdc 0mdc requested review from mosra and eundersander June 12, 2023 15:37
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 12, 2023
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc merged commit 0c89521 into SIRo Jun 13, 2023
@0mdc 0mdc deleted the siro-breaking-replay-renderer-api-change branch June 14, 2023 01:54
xavierpuigf pushed a commit that referenced this pull request Aug 23, 2023
* Fix breaking change in replay renderer api.

* Change replay renderer render api for keyword arguments.
xavierpuigf pushed a commit that referenced this pull request Aug 24, 2023
* Fix breaking change in replay renderer api.

* Change replay renderer render api for keyword arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants