-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Above" set query util #1817
Merged
Merged
"Above" set query util #1817
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
effc760
utils for getting active objects
aclegg3 281bf58
add ao_link_map getter and a general test for object scraping utils
aclegg3 4194fc6
add object getters from id and handle + tests
aclegg3 2162f6f
add above set query util
aclegg3 89b4287
Merge remote-tracking branch 'origin/main' into prepositional-logic-f…
aclegg3 b4b99b2
add tests for above
aclegg3 0025845
add test for general purpose object_keypoint_cast
aclegg3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these sim entities stable enough to be included in tests, or should we be placing new entities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming these are stable because they are ReplicaCAD scenes which we have no intention of modifying. This scene "apt_0" is a reconstruction of the first static "FRL apartment" arrangement from Replica.
If anything were to change in the future it would most likely be dynamic settling which should preserve the tested relationships here.