Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Mouse-based UI. #1908

Merged
merged 10 commits into from
Apr 12, 2024
Merged

HITL - Mouse-based UI. #1908

merged 10 commits into from
Apr 12, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Apr 11, 2024

Motivation and Context

This adds a new UI to the rearrange_v2 app with the following features:

  • Mouse-based pick and place.
  • Mouse-based open/close of articulated object links.
  • Color coding of goal object-receptacle pairs.
  • Refactoring.

Features

Here are videos showing the overall changes. Note that the instruction text was disabled for visibility, and that highlight circle billboarding is only implemented in Unity.

Double-click to open individual articulated object links:

new_ui_interact-2024-04-11_12.50.04.mp4

Double-click to pick objects, and release right click to place it:

new_ui_pick_place-2024-04-11_12.50.38.mp4

While holding right click, an indicator shows up communicating whether the object can be placed:

new_ui_place-2024-04-11_12.51.19.mp4

Experiment objects must be placed on specific receptacles. The pairs are color-coded:

new_ui_pairs-2024-04-11_12.53.11.mp4

When an action is possible, the color is green. Otherwise, it is red:

new_ui_reach-2024-04-11_12.59.16.mp4

All of this works in Unity:

new_ui_unity-2024-04-11_12.55.14.mp4

How Has This Been Tested

Tested locally and with remote Unity client.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 11, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I made a few suggestions regarding possible performance improvements, but not sure how pertinent they are.

…ted changes and fix articulated object bounding box rendering for goals.
@0mdc
Copy link
Contributor Author

0mdc commented Apr 12, 2024

Thanks John! I applied your suggestions.

@0mdc 0mdc merged commit 5e9efaa into main Apr 12, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/rearrange_v2_ui branch April 12, 2024 01:51
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
* Add selection tracking object.

* Make example selection functions static.

* Add rearrange_v2 UI class.

* Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor.

* Update controls text.

* Remove dead code.

* Improve help text.

* Show the object color code even when hovered.

* Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Add selection tracking object.

* Make example selection functions static.

* Add rearrange_v2 UI class.

* Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor.

* Update controls text.

* Remove dead code.

* Improve help text.

* Show the object color code even when hovered.

* Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Add selection tracking object.

* Make example selection functions static.

* Add rearrange_v2 UI class.

* Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor.

* Update controls text.

* Remove dead code.

* Improve help text.

* Show the object color code even when hovered.

* Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants