-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HITL - Mouse-based UI. #1908
Merged
Merged
HITL - Mouse-based UI. #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icking/placing objects and highlighting episode content. Refactor.
0mdc
requested review from
jturner65,
aclegg3,
akshararai,
xavierpuigf and
rutadesai
April 11, 2024 17:05
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Apr 11, 2024
jturner65
reviewed
Apr 11, 2024
jturner65
reviewed
Apr 11, 2024
jturner65
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I made a few suggestions regarding possible performance improvements, but not sure how pertinent they are.
…ted changes and fix articulated object bounding box rendering for goals.
Thanks John! I applied your suggestions. |
5 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jun 26, 2024
* Add selection tracking object. * Make example selection functions static. * Add rearrange_v2 UI class. * Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor. * Update controls text. * Remove dead code. * Improve help text. * Show the object color code even when hovered. * Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add selection tracking object. * Make example selection functions static. * Add rearrange_v2 UI class. * Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor. * Update controls text. * Remove dead code. * Improve help text. * Show the object color code even when hovered. * Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add selection tracking object. * Make example selection functions static. * Add rearrange_v2 UI class. * Add new mouse-based UI that allows for opening/closing receptacles, picking/placing objects and highlighting episode content. Refactor. * Update controls text. * Remove dead code. * Improve help text. * Show the object color code even when hovered. * Assorted fixes: Change scene with ZERO instead of N, performance-related changes and fix articulated object bounding box rendering for goals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds a new UI to the
rearrange_v2
app with the following features:Features
Here are videos showing the overall changes. Note that the instruction text was disabled for visibility, and that highlight circle billboarding is only implemented in Unity.
Double-click to open individual articulated object links:
new_ui_interact-2024-04-11_12.50.04.mp4
Double-click to pick objects, and release right click to place it:
new_ui_pick_place-2024-04-11_12.50.38.mp4
While holding right click, an indicator shows up communicating whether the object can be placed:
new_ui_place-2024-04-11_12.51.19.mp4
Experiment objects must be placed on specific receptacles. The pairs are color-coded:
new_ui_pairs-2024-04-11_12.53.11.mp4
When an action is possible, the color is green. Otherwise, it is red:
new_ui_reach-2024-04-11_12.59.16.mp4
All of this works in Unity:
new_ui_unity-2024-04-11_12.55.14.mp4
How Has This Been Tested
Tested locally and with remote Unity client.
Types of changes
Checklist